Fix builtins raising TypeError when compared against arbitrary type

Author: touilleMan

src/godot/builtins_pyx/operator.pyx.j2

@@ -23,18 +23,23 @@ def __repr__(self):
         gdapi.gd_string_del(&gdstr)
 {%   endif %}
 
-def __eq__(self, {{ builtin.cy_type }} other):
+def __eq__(self, object other):
+    cdef {{ builtin.c_type }}* other_gd_data
+    try:
+        other_gd_data = &(<{{ builtin.cy_type }}?>other)._gd_data
+    except TypeError:
+        return False
 {% if builtin.is_transparent_builtin %}
     return (
 {%   for field_path in  builtin.all_nested_scalar_members %}
 {%     if not loop.first%}
     and
 {%     endif %}
-    self._gd_data.{{ field_path }} == other._gd_data.{{ field_path }}
+    self._gd_data.{{ field_path }} == other_gd_data.{{ field_path }}
 {%   endfor %}
     )
 {% else %}
-    return gdapi.gd_{{ builtin.snake_name }}_op_equal_{{ builtin.snake_name }}(&self._gd_data, &other._gd_data)
+    return gdapi.gd_{{ builtin.snake_name }}_op_equal_{{ builtin.snake_name }}(&self._gd_data, other_gd_data)
 {% endif %}
 
 {% if builtin.original_name in ("Array", "Dictionary") or builtin.is_packed_array %}

tests/4-use-godot-from-python/tests/test_builtins.py

@@ -54,6 +54,8 @@ def test_scalars_and_nil_not_exposed(type: str):
         "Dictionary",
         "Array",
         "PackedArray",
+        # TODO: Callable (with conversion from a regular python function ?)
+        # TODO: Signal
     ],
 )
 def test_constructor(kind: str):
@@ -432,9 +434,13 @@ def test_operator(kind: str):
         case "equal":
             assert_eq(godot.GDString("foo") == godot.GDString("foo"), True)
             assert_eq(godot.GDString("foo") == godot.GDString("bar"), False)
+            assert_eq(godot.GDString("foo") == None, False)  # noqa: E711
+            assert_eq(godot.GDString("foo") == 42, False)
 
             assert_eq(godot.Vector2i(1, 2) == godot.Vector2i(1, 2), True)
             assert_eq(godot.Vector2i(1, 0) == godot.Vector2i(1, 2), False)
+            assert_eq(godot.Vector2i(1, 0) == None, False)  # noqa: E711
+            assert_eq(godot.Vector2i(1, 0) == 42, False)
 
             assert_eq(godot.GDArray() == godot.GDArray(), True)
             assert_eq(
@@ -443,6 +449,8 @@ def test_operator(kind: str):
                 True,
             )
             assert_eq(godot.GDArray() == godot.GDArray((1,)), False)
+            assert_eq(godot.GDArray() == None, False)  # noqa: E711
+            assert_eq(godot.GDArray() == 42, False)
 
             assert_eq(godot.GDDictionary() == godot.GDDictionary(), True)
             assert_eq(
@@ -451,6 +459,8 @@ def test_operator(kind: str):
                 True,
             )
             assert_eq(godot.GDDictionary() == godot.GDDictionary([(1, 2)]), False)
+            assert_eq(godot.GDDictionary() == None, False)  # noqa: E711
+            assert_eq(godot.GDDictionary() == 42, False)
 
         case "not_equal":
             assert_eq(godot.GDString("foo") != godot.GDString("bar"), True)