Add gnu_symbol_visibility: 'hidden' option to .so compilation

Author: touilleMan

src/godot/hazmat/gdptrs.pxd.j2

@@ -8,17 +8,22 @@ from .gdextension_interface cimport *
 
 
 cdef extern from * nogil:
-    # Global variables defined in `pythonscript_gdextension_ptrs.c`
-    # Given `libpythonscript.so` is responsible for initializing the Python
-    # interpreter, we are guanteed `pythonscript_gdapi` symbol is always
-    # resolved and set to a non-null value \o/
     """
     #include <godot/gdextension_interface.h>
     #ifdef _WIN32
     # define DLL_IMPORT __declspec(dllimport)
     #else
-    # define DLL_IMPORT
+    # define DLL_IMPORT __attribute__((visibility("default")))
     #endif
+    """
+
+
+cdef extern from * nogil:
+    # Global variables defined in `pythonscript_gdextension_ptrs.c`
+    # Given `libpythonscript.so` is responsible for initializing the Python
+    # interpreter, we are guanteed `pythonscript_gdapi` symbol is always
+    # resolved and set to a non-null value \o/
+    """
     DLL_IMPORT extern GDExtensionInterfaceGetProcAddress pythonscript_gdptr_get_proc_address;
     DLL_IMPORT extern GDExtensionClassLibraryPtr pythonscript_gdptr_library;
     """
@@ -28,12 +33,6 @@ cdef extern from * nogil:
 
 cdef extern from * nogil:
     """
-    #include <godot/gdextension_interface.h>
-    #ifdef _WIN32
-    # define DLL_IMPORT __declspec(dllimport)
-    #else
-    # define DLL_IMPORT
-    #endif
     DLL_IMPORT extern void (*pythonscript_gdptr_get_godot_version)(GDExtensionGodotVersion *r_godot_version);
     DLL_IMPORT extern void *(*pythonscript_gdptr_mem_alloc)(size_t p_bytes);
     DLL_IMPORT extern void *(*pythonscript_gdptr_mem_realloc)(void *p_ptr, size_t p_bytes);
@@ -343,12 +342,6 @@ cdef extern from * nogil:
 # Godot variant from/into Python object conversions
 cdef extern from * nogil:
     """
-    #include <godot/gdextension_interface.h>
-    #ifdef _WIN32
-    # define DLL_IMPORT __declspec(dllimport)
-    #else
-    # define DLL_IMPORT
-    #endif
     DLL_IMPORT extern GDExtensionTypeFromVariantConstructorFunc pythonscript_gdptr_object_from_variant;
     DLL_IMPORT extern GDExtensionVariantFromTypeConstructorFunc pythonscript_gdptr_object_into_variant;
     DLL_IMPORT extern GDExtensionTypeFromVariantConstructorFunc pythonscript_gdptr_bool_from_variant;
@@ -373,12 +366,6 @@ cdef extern from * nogil:
 # {{ builtin.original_name }}
 cdef extern from * nogil:
     """
-    #include <godot/gdextension_interface.h>
-    #ifdef _WIN32
-    # define DLL_IMPORT __declspec(dllimport)
-    #else
-    # define DLL_IMPORT
-    #endif
 {%   for c in builtin.constructors %}
     DLL_IMPORT extern GDExtensionPtrConstructor pythonscript_gdptr_{{ builtin.snake_name }}_constructor_{{ c.index }};
 {%   endfor %}
@@ -443,12 +430,6 @@ cdef extern from * nogil:
 # Utility functions
 cdef extern from * nogil:
     """
-    #include <godot/gdextension_interface.h>
-    #ifdef _WIN32
-    # define DLL_IMPORT __declspec(dllimport)
-    #else
-    # define DLL_IMPORT
-    #endif
 {% for utility in api.utility_functions %}
     DLL_IMPORT extern GDExtensionPtrUtilityFunction pythonscript_gdptr_utility_{{ utility.original_name }};
 {% endfor %}

src/godot/hazmat/meson.build

@@ -73,6 +73,7 @@ endif
 shared_library(
     'extension_class',
     c_extension_class,
+    gnu_symbol_visibility: 'hidden',  # Used by both clang & gcc (see https://gcc.gnu.org/wiki/Visibility)
     dependencies : [dep_godot, dep_python, dep_pythonscript],
     install_rpath: extension_class_rpath,  # To find libpython
     name_prefix: python_native_module_name_prefix,

src/godot/meson.build

@@ -128,6 +128,7 @@ shared_library(
     'builtins',
     cbuiltins,
     c_args: builtins_c_args,
+    gnu_symbol_visibility: 'hidden',  # Used by both clang & gcc (see https://gcc.gnu.org/wiki/Visibility)
     dependencies : [dep_godot, dep_python, dep_pythonscript],
     install_rpath: builtins_rpath,  # To find libpython
     name_prefix: python_native_module_name_prefix,
@@ -189,6 +190,7 @@ shared_library(
     'classes',
     cclasses,
     c_args: classes_c_args,
+    gnu_symbol_visibility: 'hidden',  # Used by both clang & gcc (see https://gcc.gnu.org/wiki/Visibility)
     dependencies : [dep_godot, dep_python, dep_pythonscript],
     install_rpath: classes_rpath,  # To find libpython
     name_prefix: python_native_module_name_prefix,

src/meson.build

@@ -286,6 +286,7 @@ lib_pythonscript = shared_library(
     'pythonscript',
     ['pythonscript.c', c_pythonscript_gdextension_ptrs, c_pythonscript],
     c_args: lib__pythonscript_c_args,
+    gnu_symbol_visibility: 'hidden',  # Used by both clang & gcc (see https://gcc.gnu.org/wiki/Visibility)
     dependencies: [dep_godot, dep_python],
     install_rpath: lib_pythonscript_rpath,  # To find libpython
     install: true,

src/pythonscript.c

@@ -20,8 +20,8 @@
 # define DLL_EXPORT __declspec(dllexport)
 # define DLL_IMPORT __declspec(dllimport)
 #else
-# define DLL_EXPORT
-# define DLL_IMPORT
+# define DLL_EXPORT __attribute__((visibility("default")))
+# define DLL_IMPORT __attribute__((visibility("default")))
 #endif
 
 #ifdef __linux__

src/pythonscript_gdextension_ptrs.c.j2

@@ -4,8 +4,8 @@
 # define DLL_EXPORT __declspec(dllexport)
 # define DLL_IMPORT __declspec(dllimport)
 #else
-# define DLL_EXPORT
-# define DLL_IMPORT
+# define DLL_EXPORT __attribute__((visibility("default")))
+# define DLL_IMPORT __attribute__((visibility("default")))
 #endif