Add (minimal) signal support to classes

Author: touilleMan

scripts/generate_tmpl.py

@@ -73,6 +73,7 @@
     "Dictionary",
     "PackedStringArray",
     "Callable",
+    "Signal",
 }
 
 

src/godot/classes.pyx.j2

@@ -219,23 +219,30 @@ cdef object _load_class(str name):
     attrs.pop("free", None)
 
     def _generate_property(spec):
-        propname = spec["name"]
+        prop_name = spec["name"]
+        prop_name_py = str(prop_name)
         @property
         def _property(self):
-            return _property_getter(self, propname)
+            return _property_getter(self, prop_name)
         @_property.setter
         def _property(self, value):
-            _property_setter(self, propname, value)
-        _property.fget.__name__ = str(spec["name"])
-        _property.fset.__name__ = str(spec["name"])
+            _property_setter(self, prop_name, value)
+        _property.fget.__name__ = prop_name_py
+        _property.fset.__name__ = prop_name_py
         return _property
 
     properties = _object_call(classdb, "class_get_property_list", [gdname])
     for prop in properties:
         attrs[str(prop["name"])] = _generate_property(prop)
 
     signals = _object_call(classdb, "class_get_signal_list", [gdname])
-    # TODO
+    for signal in signals:
+        signal_name = signal["name"]
+        signal_name_py = str(signal_name)
+        @property
+        def _signal(self):
+            return Signal(self, signal_name)
+        attrs[signal_name_py] = _signal
 
     constants = _object_call(classdb, "class_get_integer_constant_list", [gdname, True])
     for constant_name in constants:

tests/4-use-godot-from-python/tests/test_classes.py

@@ -202,8 +202,22 @@ def test_property(kind: str):
     clodotest.skip("TODO")
 
 
+@clodotest.xfail(reason="TODO: Signal constructor from object + signal name is not implemented")
 def test_signal():
-    clodotest.skip("TODO")
+    from godot.classes import Node
+
+    node = Node.new()
+    node2 = Node.new()
+    try:
+        assert_isinstance(node.ready, godot.Signal)
+        assert_eq(node.ready, node.ready)
+        assert_ne(node.ready, node.replacing_by)
+
+        # TODO: Connect a callable and emit the signal
+
+    finally:
+        node2.free()
+        node.free()
 
 
 def test_constant():