[back] fix: fix unbound variable in tournesolbot

Author: amatissart

backend/twitterbot/tests/test_tournesolbot.py

@@ -165,16 +165,19 @@ def test_get_best_criteria(self):
     @mock.patch("twitterbot.tournesolbot.get_twitter_account_from_video_id")
     def test_prepare_tweet(self, mock_get_twitter_account_from_video_id):
 
-        tweet_text = (
+        message_text = (
             "Aujourd'hui, je recommande 'Tournesol is great! 🌻 #tournesol' de @TournesolApp, "
             "comparée 77 fois sur #Tournesol🌻 par 28 contributeurs, critères favoris:"
             "\n- Important & actionnable\n- Stimulant & suscite la réflexion"
-            "\ntournesol.app/entities/yt:AAAAAAAAAAA"
         )
+        message_end = "\ntournesol.app/entities/yt:AAAAAAAAAAA"
 
         mock_get_twitter_account_from_video_id.return_value = "@TournesolApp"
 
-        assert prepare_text(self.videos[8], dest="twitter") == tweet_text
+        assert prepare_text(self.videos[8], dest="twitter") == message_text + message_end
+        assert prepare_text(self.videos[8], dest="bluesky") == message_text.replace(
+            "@TournesolApp", "'Tournesol'"
+        )
 
         # Test automatic shortening of the video title to fit in the tweet
         self.videos[8].metadata[
@@ -187,12 +190,15 @@ def test_prepare_tweet(self, mock_get_twitter_account_from_video_id):
             "contributeurs, critères favoris:"
             "\n- Important & actionnable"
             "\n- Stimulant & suscite la réflexion"
-            "\ntournesol.app/entities/yt:AAAAAAAAAAA"
         )
+        message_end = "\ntournesol.app/entities/yt:AAAAAAAAAAA"
 
-        assert prepare_text(self.videos[8], dest="twitter") == tweet_text_too_long
+        assert prepare_text(self.videos[8], dest="twitter") == tweet_text_too_long + message_end
+        assert prepare_text(self.videos[8], dest="bluesky").startswith(
+            "Aujourd'hui, je recommande 'Tournesol is great!"
+        )
 
-        # Test replacement of special characters in the video title
+        # Test replacement of special characters in the video title for Twitter
         self.videos[8].metadata["name"] = "Tournesol.app is great but mention @twitter are not..."
 
         tweet_special_characters = (

backend/twitterbot/tournesolbot.py

@@ -69,9 +69,10 @@ def prepare_text(video: Entity, dest: Literal["twitter", "bluesky"]):
         CriteriaLocale.objects.filter(language=language).values_list("criteria__name", "label")
     )
 
+    video_title = video.metadata["name"]
     if dest == "twitter":
         # Replace "@" by a smaller "@" to avoid false mentions in the tweet
-        video_title = video.metadata["name"].replace("@", "﹫")
+        video_title = video_title.replace("@", "﹫")
 
         # Replace "." in between words to avoid in the tweet false detection of links
         video_title = re.sub(r"\b(?:\.)\b", "․", video_title)