Skip to content

Commit 81b8231

Browse files
authored
ci: Switch cargo-public-api-crates to cargo-check-external-types (#613)
1 parent 1fb0144 commit 81b8231

File tree

2 files changed

+20
-24
lines changed

2 files changed

+20
-24
lines changed

.github/workflows/CI.yml

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -95,20 +95,17 @@ jobs:
9595
manifest-path: tower-http/Cargo.toml
9696
command: check ${{ matrix.checks }}
9797

98-
cargo-public-api-crates:
98+
external-types:
9999
runs-on: ubuntu-latest
100100
steps:
101101
- uses: actions/checkout@v5
102-
# Pinned version due to failing `cargo-public-api-crates`.
103102
- uses: dtolnay/rust-toolchain@master
104103
with:
105-
toolchain: nightly-2025-11-23
104+
toolchain: nightly-2025-08-06
105+
- name: Install cargo-check-external-types
106+
uses: taiki-e/cache-cargo-install-action@v2
107+
with:
108+
106109
- uses: Swatinem/rust-cache@v2
107-
- name: Install cargo-public-api-crates
108-
run: |
109-
cargo install --git https://github.com/jplatte/cargo-public-api-crates
110-
- name: Build rustdoc
111-
run: |
112-
cargo rustdoc --all-features --manifest-path tower-http/Cargo.toml -- -Z unstable-options --output-format json
113-
- name: cargo public-api-crates check
114-
run: cargo public-api-crates --manifest-path tower-http/Cargo.toml --skip-build check
110+
- run: cargo check-external-types --all-features
111+
working-directory: tower-http

tower-http/Cargo.toml

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -124,17 +124,16 @@ rustdoc-args = ["--cfg", "docsrs"]
124124
[package.metadata.playground]
125125
features = ["full"]
126126

127-
[package.metadata.cargo-public-api-crates]
128-
allowed = [
129-
"bytes",
130-
"http",
131-
"http_body",
132-
"mime",
133-
"pin-project-lite",
134-
"tokio",
135-
"tower",
136-
"tower_layer",
137-
"tower_service",
138-
"tracing",
139-
"tracing_core",
127+
[package.metadata.cargo_check_external_types]
128+
allowed_external_types = [
129+
"bytes::*",
130+
"http::*",
131+
"http_body::*",
132+
"mime::*",
133+
"tokio::*",
134+
"tower::*",
135+
"tower_layer::*",
136+
"tower_service::*",
137+
"tracing::*",
138+
"tracing_core::*",
140139
]

0 commit comments

Comments
 (0)