Skip to content

Commit 2636f51

Browse files
baijumclaude
andcommitted
fix: add DNS and env_file to Caddy in bootstrap script
- Add dns (8.8.8.8, 1.1.1.1) to Caddy service so it can reach ACME endpoints from within Docker bridge network - Add env_file to Caddy service so it picks up ACME_EMAIL - Add ACME_EMAIL placeholder to generated credentials file - Update next steps to reflect fewer required GitHub secrets Discovered during hello-world multi-app deployment test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent d2b9c9d commit 2636f51

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

infrastructure/bootstrap-server.sh

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ else
138138
POSTGRES_PASSWORD=${POSTGRES_PASSWORD}
139139
MINIO_ROOT_USER=${MINIO_ROOT_USER}
140140
MINIO_ROOT_PASSWORD=${MINIO_ROOT_PASSWORD}
141+
ACME_EMAIL=admin@localhost
141142
EOF
142143

143144
chmod 600 "$ENV_FILE"
@@ -223,6 +224,10 @@ services:
223224
caddy:
224225
image: caddy:2
225226
restart: unless-stopped
227+
env_file: .env
228+
dns:
229+
- 8.8.8.8
230+
- 1.1.1.1
226231
ports:
227232
- "80:80"
228233
- "443:443"
@@ -302,7 +307,8 @@ echo
302307
echo "Next steps:"
303308
echo " 1. Add your SSH public key to /home/deploy/.ssh/authorized_keys"
304309
echo " 2. Configure DNS — point your domain to this server's IP"
305-
echo " 3. Set GitHub Actions secrets on your app repo:"
306-
echo " SERVER_HOST, SERVER_USER (deploy), SERVER_SSH_KEY,"
307-
echo " APP_DOMAIN, DATABASE_PASSWORD, MINIO_ROOT_USER, MINIO_ROOT_PASSWORD"
308-
echo " 4. Push to main — deployment runs automatically"
310+
echo " 3. Update ACME_EMAIL in $ENV_FILE to a real email for TLS certificates"
311+
echo " 4. Set GitHub Actions secrets on your app repo:"
312+
echo " SERVER_HOST, SERVER_USER (deploy), SERVER_SSH_KEY, APP_DOMAIN"
313+
echo " 5. Create app dir, clone repo, create deploy/.env from template"
314+
echo " 6. Push to main — deployment runs automatically"

0 commit comments

Comments
 (0)