This repository was archived by the owner on Nov 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathindex.html
More file actions
237 lines (231 loc) · 12.1 KB
/
Copy pathindex.html
File metadata and controls
237 lines (231 loc) · 12.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
<!DOCTYPE html>
<html lang='en'>
<head>
<meta charset='utf-8' />
<meta content='width=1024' name='viewport' />
<meta content='yes' name='apple-mobile-web-app-capable' />
<title>
Refactoring Considered Harmful
</title>
<meta content='A brief, interactive presentation on the evils of refactoring' name='description' />
<meta content='Tyler Pickett' name='author' />
<link href='http://fonts.googleapis.com/css?family=Montserrat+Alternates|Droid+Sans+Mono' rel='stylesheet' />
<link href='css/harmful.css' rel='stylesheet' />
<link href='favicon.png' rel='shortcut icon' />
<link href='apple-touch-icon.png' rel='apple-touch-icon' />
</head>
<body class='impress-not-supported'>
<div class='fallback-message'>
<p>
Your browser
<b>doesn't support all of the features required</b>
by impress.js, so you are presented with a simplified version of this presentation.
</p>
<p>
For the best experience please use the latest version of Chrome, Safari or Firefox
</p>
</div>
<div id='impress'>
<div class='step' data-scale='2' data-x='0' data-y='0' id='fake-title'></div>
<div class='step' data-scale='2' data-x='0' data-y='0' id='title'>
<div class='not'>
Not
</div>
Refactoring
<br />
Considered
<br />
Harmful
</div>
<div class='step' data-x='0' data-y='1024' id='whoami'>
Tyler Pickett
<br />
Twitter/Github: tpickett66
</div>
<div class='section step' data-rotate='90' data-scale='2' data-x='2000' data-y='1024' id='what'>
What?
</div>
<div class='step' data-rotate='90' data-x='2100' data-y='1500' data-z='-2100' id='wikipedia'>
<div class='title'>Wikipedia</div>
<div class='text'>
<b>Code refactoring</b>
is a "disciplined technique for restructing and existing body of code,
altering its internal structure without changing its external
behavior"<sup>1</sup>, undertaken in order to improve some nonfunctional
attributes of the software. Advantages include improved code
readability and reduced complexity to improve the maintainability of
the source code, as well as a more expressive internal architecture or
object model to improve extensibility.
</div>
<div class='note'>
<ol>
<li>
Martin Fowler
<a href='http://refactoring.com/'>refactoring.com</a>
</li>
</ol>
</div>
</div>
<div class='step' data-rotate='120' data-x='1400' data-y='1800' data-z='-1400' id='blah'>
<div class='first'>blah</div>
<div class='second'>Blah!</div>
<div class='third'>BLAH!</div>
</div>
<div class='step' data-rotate='150' data-x='700' data-y='2100' data-z='-700' id='suck-less'>
TL;DR: Make your code suck less.
</div>
<div class='section step' data-rotate='180' data-scale='2' data-x='0' data-y='2400' id='why'>
Why?
</div>
<div class='step' data-rotate='180' data-x='0' data-y='2400' data-z='-2100' id='maintenance'>
Maintenance
</div>
<div class='step' data-rotate='210' data-x='-800' data-y='1600' data-z='-1400' id='conversation'>
<p class='quote'>"Code is a conversation with the reader"</p>
<p class='attribution'>Unknown</p>
</div>
<div class='step' data-rotate='240' data-x='-1600' data-y='800' data-z='-700' id='james'>
<div class='name'>jamescarr</div>
I just know that when I see a few hundred lines of
procedural hogwash with view and database logic in
the controller the author intended to tell me to go F myself
</div>
<div class='section step' data-rotate='270' data-scale='2' data-x='-2400' data-y='0' id='who'>
Who?
</div>
<div class='step' data-rotate='270' data-x='-2400' data-y='0' data-z='-2100' id='ruby'>
Ruby users?
</div>
<div class='step' data-rotate='300' data-x='-1600' data-y='-800' data-z='-1400' id='haskell'>
Haskell users?
</div>
<div class='step' data-rotate='330' data-x='-800' data-y='-1600' data-z='-700' id='designers'>
Designers?
</div>
<div class='section step' data-rotate='360' data-scale='2' data-x='0' data-y='-2400' id='how'>
How?
</div>
<div class='step code-example' data-x='0' data-y='-4000'>
<table class="highlighttable"><tr><td class="linenos"><div class="linenodiv"><pre> 1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20</pre></div></td><td class="code"><div class="highlight"><pre><span class="k">class</span> <span class="nc">EDIDigesterFactory</span>
<span class="c1"># 60 lines of unintersting stuff</span>
<span class="kp">private</span>
<span class="k">def</span> <span class="nf">find_isa_segments</span><span class="p">(</span><span class="n">file_contents</span><span class="p">)</span>
<span class="vi">@isa_indices</span> <span class="o">=</span> <span class="o">[</span><span class="mi">0</span><span class="o">]</span>
<span class="n">delimeter</span> <span class="o">=</span> <span class="n">file_contents</span><span class="o">[</span><span class="mi">105</span><span class="p">,</span><span class="mi">1</span><span class="o">]</span>
<span class="n">regex</span> <span class="o">=</span> <span class="sr">/[</span><span class="si">#{</span><span class="n">delimeter</span><span class="si">}</span><span class="sr">]?ISA([\*\|])0[0|3]\1.{10}\1[0][0|1]\1.{10}\1.{2}\1.{15}</span>
<span class="sr"> \1.{2}\1.{15}\1\d{6}\1\d{4}\1.\1\d{5}\1.{9}\1[0|1]\1[P|T]\1.</span><span class="si">#{</span><span class="n">delimeter</span><span class="si">}</span><span class="sr">/x</span>
<span class="k">until</span> <span class="vi">@isa_indices</span><span class="o">.</span><span class="n">last</span><span class="o">.</span><span class="n">nil?</span>
<span class="n">found_index</span> <span class="o">=</span> <span class="n">file_contents</span><span class="o">.</span><span class="n">index</span><span class="p">(</span><span class="n">regex</span><span class="p">,</span><span class="vi">@isa_indices</span><span class="o">.</span><span class="n">last</span> <span class="o">+</span> <span class="mi">105</span><span class="p">)</span>
<span class="n">found_index</span> <span class="o">+=</span> <span class="mi">1</span> <span class="k">if</span> <span class="o">!</span><span class="n">found_index</span><span class="o">.</span><span class="n">nil?</span> <span class="o">&&</span> <span class="n">file_contents</span><span class="o">[</span><span class="n">found_index</span><span class="p">,</span><span class="mi">1</span><span class="o">]</span> <span class="o">!=</span> <span class="s2">"I"</span>
<span class="vi">@isa_indices</span> <span class="o"><<</span> <span class="n">found_index</span>
<span class="k">end</span>
<span class="vi">@envelopes_found</span> <span class="o">=</span> <span class="vi">@isa_indices</span><span class="o">.</span><span class="n">size</span>
<span class="vi">@isa_indices</span><span class="o">.</span><span class="n">compact!</span>
<span class="k">end</span>
<span class="c1"># 40 + more lines of more crap</span>
<span class="k">end</span>
</pre></div>
</td></tr></table>
</div>
<div class='step code-example' data-x='1080' data-y='-4000'>
<table class="highlighttable"><tr><td class="linenos"><div class="linenodiv"><pre> 1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19</pre></div></td><td class="code"><div class="highlight"><pre><span class="k">class</span> <span class="nc">EDIDigesterFactory</span>
<span class="k">def</span> <span class="nf">find_isa_segments</span><span class="p">(</span><span class="n">file_contents</span><span class="p">)</span>
<span class="k">return</span> <span class="vi">@_isa_indices</span> <span class="k">unless</span> <span class="vi">@_isa_indices</span><span class="o">.</span><span class="n">nil?</span>
<span class="n">identifier</span> <span class="o">=</span> <span class="no">ISASegmentIdentifier</span><span class="o">.</span><span class="n">new</span><span class="p">(</span><span class="n">file_contents</span><span class="p">)</span>
<span class="vi">@_isa_indices</span> <span class="o">=</span> <span class="n">identifier</span><span class="o">.</span><span class="n">find_indices</span>
<span class="k">end</span>
<span class="k">end</span>
<span class="k">class</span> <span class="nc">ISASegmentIdentifier</span>
<span class="kp">attr_reader</span> <span class="ss">:file_contents</span>
<span class="k">def</span> <span class="nf">initialize</span><span class="p">(</span><span class="n">file_contents</span><span class="p">)</span>
<span class="vi">@file_contents</span> <span class="o">=</span> <span class="n">file_contents</span>
<span class="k">end</span>
<span class="k">def</span> <span class="nf">find_indices</span>
<span class="c1"># big nasty method copied here...</span>
<span class="k">end</span>
<span class="k">end</span>
</pre></div>
</td></tr></table>
</div>
<div class='step code-example' data-x='2160' data-y='-4000'>
<table class="highlighttable"><tr><td class="linenos"><div class="linenodiv"><pre> 1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17</pre></div></td><td class="code"><div class="highlight"><pre><span class="k">class</span> <span class="nc">ISASegmentIdentifier</span>
<span class="kp">attr_reader</span> <span class="ss">:file_contents</span>
<span class="k">def</span> <span class="nf">initialize</span><span class="p">(</span><span class="n">file_contents</span><span class="p">);</span> <span class="k">end</span>
<span class="k">def</span> <span class="nf">find_indices</span>
<span class="n">isa_indices</span> <span class="o">=</span> <span class="o">[</span><span class="mi">0</span><span class="o">]</span>
<span class="n">delimeter</span> <span class="o">=</span> <span class="n">file_contents</span><span class="o">[</span><span class="mi">105</span><span class="p">,</span><span class="mi">1</span><span class="o">]</span>
<span class="n">regex</span> <span class="o">=</span> <span class="sr">/[</span><span class="si">#{</span><span class="n">delimeter</span><span class="si">}</span><span class="sr">]?ISA([\*\|])0[0|3]\1.{10}\1[0][0|1]\1.{10}\1.{2}\1.{15}</span>
<span class="sr"> \1.{2}\1.{15}\1\d{6}\1\d{4}\1.\1\d{5}\1.{9}\1[0|1]\1[P|T]\1.</span><span class="si">#{</span><span class="n">delimeter</span><span class="si">}</span><span class="sr">/x</span>
<span class="k">until</span> <span class="n">isa_indices</span><span class="o">.</span><span class="n">last</span><span class="o">.</span><span class="n">nil?</span>
<span class="n">found_index</span> <span class="o">=</span> <span class="n">file_contents</span><span class="o">.</span><span class="n">index</span><span class="p">(</span><span class="n">regex</span><span class="p">,</span><span class="n">isa_indices</span><span class="o">.</span><span class="n">last</span> <span class="o">+</span> <span class="mi">105</span><span class="p">)</span>
<span class="n">found_index</span> <span class="o">+=</span> <span class="mi">1</span> <span class="k">if</span> <span class="o">!</span><span class="n">found_index</span><span class="o">.</span><span class="n">nil?</span> <span class="o">&&</span> <span class="n">file_contents</span><span class="o">[</span><span class="n">found_index</span><span class="p">,</span><span class="mi">1</span><span class="o">]</span> <span class="o">!=</span> <span class="s2">"I"</span>
<span class="n">isa_indices</span> <span class="o"><<</span> <span class="n">found_index</span>
<span class="k">end</span>
<span class="n">isa_indices</span><span class="o">.</span><span class="n">compact</span>
<span class="k">end</span>
<span class="k">end</span>
</pre></div>
</td></tr></table>
</div>
</div>
<script src='js/impress.js'></script>
<script type='text/javascript'>
//<![CDATA[
impress().init();
//]]>
</script>
</body>
</html>