[fix]: Handle open-show-all-data in background.js to prevent duplicate tabs

Move shortcut handling out of popup.js (where it fired on every open
Salesforce tab due to chrome.runtime.sendMessage broadcast) into
background.js. Uses chrome.tabs.query to get the active tab and the
existing cookie-based sfHost resolution, then opens inspect.html
directly via chrome.tabs.create — no broadcast involved.

Author: RubenHalman

addon/background.js

@@ -81,6 +81,33 @@ chrome.commands?.onCommand.addListener((command) => {
       url: `https:///${sfHost}${link}`
     });
 
+  } else if (command === "open-show-all-data") {
+    chrome.tabs.query({active: true, currentWindow: true}, tabs => {
+      let tab = tabs[0];
+      if (!tab?.url) return;
+      let tabUrl = tab.url;
+      let currentDomain;
+      try { currentDomain = new URL(tabUrl).hostname; } catch { return; }
+      chrome.cookies.get({url: tabUrl, name: "sid", storeId: tab.cookieStoreId}, cookie => {
+        if (!cookie || currentDomain.endsWith(".mcas.ms")) {
+          openShowAllData(currentDomain, tabUrl);
+          return;
+        }
+        const [orgId] = cookie.value.split("!");
+        const orderedDomains = ["salesforce.com", "cloudforce.com", "salesforce.mil", "cloudforce.mil", "sfcrmproducts.cn", "force.com"];
+        let resolved = false;
+        orderedDomains.forEach(domain => {
+          chrome.cookies.getAll({name: "sid", domain, secure: true, storeId: tab.cookieStoreId}, cookies => {
+            if (resolved) return;
+            let sessionCookie = cookies.find(c => c.value.startsWith(orgId + "!") && c.domain != "help.salesforce.com");
+            if (sessionCookie) {
+              resolved = true;
+              openShowAllData(sessionCookie.domain, tabUrl);
+            }
+          });
+        });
+      });
+    });
   } else if (command.startsWith("open-")){
     chrome.runtime.sendMessage({
       msg: "shortcut_pressed", command, sfHost
@@ -118,4 +145,28 @@ async function clearSobjectsListCache() {
     console.error("Error clearing sobjectsList cache on update:", e);
   }
 }
+function openShowAllData(host, tabUrl) {
+  let url;
+  try { url = new URL(tabUrl); } catch { return; }
+  let sobject = null;
+  let sobjectMatch = url.pathname.match(/\/lightning\/[ro]\/([a-zA-Z0-9_]+)\/[a-zA-Z0-9]+/);
+  if (sobjectMatch) sobject = sobjectMatch[1];
+  let recordId = null;
+  if (url.pathname.includes("/builder_platform_interaction/flowBuilder.app")) {
+    let flowId = url.searchParams.get("flowId");
+    if (flowId?.startsWith("301")) recordId = flowId;
+  } else {
+    for (let p of url.pathname.split("/")) {
+      if (p.match(/^([a-zA-Z0-9]{3}|[a-zA-Z0-9]{15}|[a-zA-Z0-9]{18})$/) && p.includes("0000")) {
+        recordId = p;
+        break;
+      }
+    }
+  }
+  let args = new URLSearchParams();
+  args.set("host", host);
+  if (sobject) args.set("objectType", sobject);
+  if (recordId) args.set("recordId", recordId);
+  chrome.tabs.create({url: chrome.runtime.getURL("inspect.html?" + args)});
+}
 chrome.runtime.setUninstallURL("https://forms.gle/y7LbTNsFqEqSrtyc6");

addon/popup.js

@@ -36,7 +36,7 @@ if (typeof browser === "undefined") {
     if (request.msg === "shortcut_pressed") {
       if (request.command === "open-popup") {
         parent.postMessage({insextOpenPopup: true}, "*");
-      } else if (request.command !== "open-show-all-data") {
+      } else {
         parent.postMessage({command: request.command}, "*");
       }
     } else if (request.message === "tokenUpdated" && request.sfHost) {
@@ -138,7 +138,6 @@ class App extends React.PureComponent {
     };
     this.onContextUrlMessage = this.onContextUrlMessage.bind(this);
     this.onShortcutKey = this.onShortcutKey.bind(this);
-    this.onShowAllDataShortcut = this.onShowAllDataShortcut.bind(this);
     this.onChangeApi = this.onChangeApi.bind(this);
     this.onContextRecordChange = this.onContextRecordChange.bind(this);
     this.updateReleaseNotesViewed = this.updateReleaseNotesViewed.bind(this);
@@ -326,31 +325,12 @@ class App extends React.PureComponent {
     let {sfHost} = this.props;
     addEventListener("message", this.onContextUrlMessage);
     addEventListener("keydown", this.onShortcutKey);
-    chrome.runtime.onMessage.addListener(this.onShowAllDataShortcut);
     parent.postMessage({insextLoaded: true}, "*");
     setOrgInfo(this.props.sfHost);
   }
   componentWillUnmount() {
     removeEventListener("message", this.onContextUrlMessage);
     removeEventListener("keydown", this.onShortcutKey);
-    chrome.runtime.onMessage.removeListener(this.onShowAllDataShortcut);
-  }
-  onShowAllDataShortcut(request) {
-    if (request.msg === "shortcut_pressed" && request.command === "open-show-all-data") {
-      let {sfHost} = this.props;
-      let {contextUrl} = this.state;
-      let recordId = contextUrl && getRecordId(contextUrl);
-      let sobject = contextUrl && getSobject(contextUrl);
-      let args = new URLSearchParams();
-      args.set("host", sfHost);
-      if (sobject) {
-        args.set("objectType", sobject);
-      }
-      if (recordId) {
-        args.set("recordId", recordId);
-      }
-      window.open(chrome.runtime.getURL("inspect.html?" + args), "_blank");
-    }
   }
   isMac() {
     return navigator.userAgentData?.platform.toLowerCase().indexOf("mac") > -1 || navigator.userAgent.toLowerCase().indexOf("mac") > -1;