Skip to content

CI flake: deploy replication-retry test — generic "exited with code 1" instead of parsed replication signature under runner load #699

Description

@tps-flint

On PR #698 (run for commit 30785d0), deploy.test.ts "--deploy-retries 0 disables retry" failed on two unit lanes with Received: "harper deploy exited with code 1" where the expected /peer replication failed after 1 attempt/ signature should have been parsed from the scripted fake harper binary's output. All 37 deploy tests pass locally on the same commit, and the replication-detection code is untouched by the PR (verified by diff hunks). Signature-shape hypothesis: a spawn output-drain race — under CI load the child's stdout/stderr isn't fully consumed before the non-zero exit is turned into the generic error, so the signature matcher sees nothing. Suggested fix: await stream close (not just exit) before classifying the failure, in deploy()'s child-process handling.

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions