Missing optical adjustment options + A bug

[Signupsforeverything]

Hello!

(Minecraft 1.21.8 / Fabric 1.1.0) - (First Person v2.5.0 / NotEnoughAnimations v1.10.2)
Based on the following pictures, I would like to ask, if you could add some additional options to the mod.
And an animation for the arms while fishing.

If you need a full list of all the mods and resource packs I have installed, I will gladly provide.

1. Fishing
   As you can see, the fishing line is disconnected from the fishing rod. It's even worse, if the fishing rod is marked as an held up item. Could you make it so that the end point of the line follows the end of the fishing rod? For the arm animation to hold the fishing rod, I was imagining to reuse the main-offhand swap animation, and hold it when the hands touch.

2. Riding A Horse
   My view is pretty blocked by the items I hold. I would like an option to blend out the held items while riding, if they aren't used.
   Maybe with an adjustable cooldown before the items are blended out again after using them.

3. Individual held item rotation settings needed.
   The lantern (Better Lanterns v1.2) is in my case held like a flashlight. I would like to rotate it down.
   But without also effecting other held up items, to not mess those up in consequence.

4. BUG: It looks like a slider is not working. :(
   In this picture I want to show which items are selected to be held up and that all settings are on default.
   (Torches Reimagined v1.5)

In this picture I moved the holding arm position to y(-0.5).
But there is no difference to y(0).

No change for holding arm position y(+0.4).

But the holding arm x-adjustments work!

If the y-slider is supposed to do something else, I couldn't see what had changed.
To point 3 again, the flames of the torch are clipping through my head. But it can't be rotated as much as the lantern requires, without going to look weird, if all held items share the same rotation value.

[elenawinters]

The suggestion for a fishing rod animation is being tracked at #179. This is something I plan to work on soon. As for the other things:

• 1. The disconnected fishing rod line is being tracked at Fishing Line doesn't attach to rod and compatibility with Tide FirstPersonModel#547.
• 2. I'm interested in seeing what can be done to mitigate this. Might be cool to keep the held items at the sides of the players legs while horse riding unless the items are/were in use? Will look into it unless TR wants to.
• 3. I recommend looking at Extended Illumina /w NEA support or Turnip's Animated Lanterns /w NEA support for the time being. I'll take a look at what can be done on NEA's side to support stuff like that at some point.
• 4. Took a look at the code, and this is just very poorly explained in the config screen. config.holdUpItemOffset doesn't do anything if config.holdUpTarget is set to CAMERA. If you were to set the Hold Up Target to NONE, the slider would work normally.

[Signupsforeverything]

@elenawinters

to points i and ii:
Alright! I'm looking forward to it. 🙂 I hope everything works out.

to point ii:
I think I saw a similar feature in the options, that would do something like that, but it's marked for removal, because it causes problems I think was mentioned. 🤔

to point iii:
I had a quick look into the resource files of Better Lanterns v1.2 and Extended Illumina, and it looks like there is .json in
Extended Illumina that modifies the lanter-item's position/orientation when held in the hand. I wonder if you could adapt this for NEA and if the file's values can be manipulated with sliders, like the arm position what you already do, and it's already per item, so there is no need to crate extra files, just manipulating the correct one, I imagine.

Also, in Beltborn Lanters, the lantern has physics. Would it look cool, if the lantern in the hand could swing around too?

to point iv:
I think the option for the holding-arm-offsets is unnecessarily limited in its possibilities.
If it is set to "follow camera", just let the sliders adjust the offset of the item-holding-arm how it points towards the camera.
If set to "NONE", just let the sliders adjust the offset of the item-holding-arm how it points towards the standard direction.
This way one doesn't have to choose which axis they want to be able to effect, +- camera.
I see no point in it being like that.

[Signupsforeverything]

I figured out how to adjust the rotation and position of the torch from §eTorches§8-§eReimagined§0_§8[v1.5]§0 in the resource pack's torch.json file!

(On the contrary, at some point the mod Beltborn Lanters stopped working sort of.
The lantern on the hip won't emit light anymore and I don't know why... :[ )

[elenawinters]

NEA doesn't do anything to show items at the hips. The closest is Scabbard Sword, which while part of NEA, is due for removal.

[tr7zw]

FYI 3d lanterns with physics is now built into the mod itself.