🩹 Fix

Author: H1rono

internal/router/middleware.go

@@ -39,7 +39,7 @@ func (h Handlers) AccessLoggingMiddleware(next echo.HandlerFunc) echo.HandlerFun
 		start := time.Now()
 		err := next(c)
 		if err != nil {
-			defaultHttpErrorHandler(c, HTTPErrorHandlerInner(err))
+			defaultHTTPErrorHandler(c, HTTPErrorHandlerInner(err))
 		}
 		stop := time.Now()
 
@@ -48,7 +48,8 @@ func (h Handlers) AccessLoggingMiddleware(next echo.HandlerFunc) echo.HandlerFun
 		if uErr != nil {
 			logger := logging.GetLogger(req.Context())
 			logger.Error("failed to unwrap response", zap.Error(uErr))
-			return uErr
+			// ここでreturn uErrとはしない; アクセスログの失敗はリクエストの失敗ではないため
+			return nil
 		}
 		logger := logging.GetLogger(req.Context())
 		latency := strconv.FormatFloat(stop.Sub(start).Seconds(), 'f', 9, 64) + "s"

internal/router/router.go

@@ -24,7 +24,7 @@ type Handlers struct {
 	SessionName    string
 }
 
-var defaultHttpErrorHandler = echo.DefaultHTTPErrorHandler(false)
+var defaultHTTPErrorHandler = echo.DefaultHTTPErrorHandler(false)
 
 func (h Handlers) NewServer(logger *zap.Logger) *echo.Echo {
 	e := echo.New()
@@ -33,7 +33,7 @@ func (h Handlers) NewServer(logger *zap.Logger) *echo.Echo {
 		logger := logging.GetLogger(c.Request().Context())
 		logger.Debug("handling error", zap.Error(err))
 		he := HTTPErrorHandlerInner(err)
-		defaultHttpErrorHandler(c, he)
+		defaultHTTPErrorHandler(c, he)
 	}
 	e.Use(middleware.RequestID())
 	e.Use(h.setLoggerMiddleware(logger))