Open
Description
In a revision diff page, with a customised 'from' and 'to' revisions (as we normally batch review a range of changesets), I could still make comments there. However, there are two problems:
-
the link in the comments page does not get me back to the diff page, instead, it bring me to the latest changeset regarding to the 'to' revision.
-
the comments in the page have wrong positions.
It seems to be related with the following code in web.py
def changeset_js_data(self, req, data):
return {
'page': 'changeset',
'revision': data['new_rev'],
'path': data['reponame'],
'selectorToInsertAfter': 'div.diff div.diff:last'
}
Apparently, only the reponame, and last revision is stored, instead of the actual diff. I wonder if it would be possible if the full browser URL is stored inside the 'path' column instead?
Metadata
Metadata
Assignees
Labels
No labels