Improve SSH key filename validation in interactive mode (#86)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: dancho-atanasov-tracebit

.gitignore

@@ -243,7 +243,7 @@ _Pvt_Extensions
 
 # Claude AI assistant
 CLAUDE.md
-**/.claude/settings.local.json
+**/.claude/**
 
 # Portal sample credentials
 azure_cert.pem

Tracebit.Cli.Tests/Commands/UtilsTests.cs

@@ -98,4 +98,21 @@ public void GetCurrentVersion_ReturnsVersion()
         Assert.NotNull(version);
         Assert.True(version.Major >= 0);
     }
+
+    [Theory]
+    [InlineData("tracebit-key.pem", true)]
+    [InlineData("my_ssh_key", true)]
+    [InlineData("key123", true)]
+    [InlineData("id_rsa", true)]
+    [InlineData("", false)]
+    [InlineData("key with spaces.pem", false)]
+    [InlineData("\tkey.pem", false)]
+    [InlineData("path/to/key.pem", false)]
+    [InlineData("path\\to\\key.pem", false)]
+    public void IsValidSshKeyFileName_ValidatesFileName(string input, bool expected)
+    {
+        var result = Utils.IsValidSshKeyFileName(input);
+
+        Assert.Equal(expected, result);
+    }
 }

Tracebit.Cli/Commands/Deploy.cs

@@ -688,7 +688,6 @@ private static Command DeployCanaryCredentialsCommand(string type, string descri
         defaultName = defaultNameExists ? $"{defaultName}-{Utils.GenerateRandomString(5)}" : defaultName;
         var name = await AnsiConsole.PromptAsync(TextPrompts.NamePrompt(defaultName), cancellationToken);
         var labels = _labelsParsing(await AnsiConsole.PromptAsync(TextPrompts.LabelsPrompt, cancellationToken));
-        // NOTE: only does a whitespace check for now, not legal filename checks yet like how the option does AcceptLegalFileNamesOnly()
         var sshKeyFileName = await AnsiConsole.PromptAsync(TextPrompts.SshKeyFileNamePrompt(defaultSshKeyFileName), cancellationToken);
         AnsiConsole.WriteLine();
         return (name, labels, sshKeyFileName);

Tracebit.Cli/Commands/TextPrompts.cs

@@ -48,7 +48,7 @@ public static TextPrompt<string> SshKeyFileNamePrompt(string defaultSshKeyFileNa
             .DefaultValue(defaultSshKeyFileName)
             .DefaultValueStyle(Style.Parse("silver"))
             .Validate(s =>
-                s.Any(char.IsWhiteSpace)
-                    ? ValidationResult.Error("Whitespace in name not supported")
-                    : ValidationResult.Success());
+                Utils.IsValidSshKeyFileName(s)
+                    ? ValidationResult.Success()
+                    : ValidationResult.Error("Invalid SSH key file name: provide a file name (not a path) with no spaces or special characters"));
 }

Tracebit.Cli/Commands/Utils.cs

@@ -131,6 +131,20 @@ public static bool IsLabelFormat(string input)
         return LabelFormat().IsMatch(input);
     }
 
+    public static bool IsValidSshKeyFileName(string fileName)
+    {
+        if (string.IsNullOrEmpty(fileName))
+            return false;
+        if (fileName.Any(char.IsWhiteSpace))
+            return false;
+        if (fileName.IndexOfAny(Path.GetInvalidFileNameChars()) >= 0)
+            return false;
+        // Ensure it's a file name and not a path (check both separators regardless of platform)
+        if (fileName.Contains('/') || fileName.Contains('\\'))
+            return false;
+        return true;
+    }
+
     public static void PrintCanaryRemovalFailedUsingForce(string reason)
     {
         AnsiConsole.MarkupLineInterpolated(