Skip to content

Commit a83d64b

Browse files
committed
Really disable log messages for feature computation when we ask them to be off.
1 parent 49e5d28 commit a83d64b

5 files changed

Lines changed: 27 additions & 13 deletions

File tree

src/main/java/fiji/plugin/trackmate/TrackMate.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public boolean computeSpotFeatures( final boolean doLogIt )
160160
cancelables.clear();
161161

162162
final Logger logger = model.getLogger();
163-
final SpotFeatureCalculator calculator = new SpotFeatureCalculator( model, settings );
163+
final SpotFeatureCalculator calculator = new SpotFeatureCalculator( model, settings, doLogIt );
164164
cancelables.add( calculator );
165165
calculator.setNumThreads( numThreads );
166166
if ( calculator.checkInput() && calculator.process() )
@@ -201,7 +201,7 @@ public boolean computeEdgeFeatures( final boolean doLogIt )
201201
cancelables.clear();
202202

203203
final Logger logger = model.getLogger();
204-
final EdgeFeatureCalculator calculator = new EdgeFeatureCalculator( model, settings );
204+
final EdgeFeatureCalculator calculator = new EdgeFeatureCalculator( model, settings, doLogIt );
205205
cancelables.add( calculator );
206206
calculator.setNumThreads( numThreads );
207207
if ( !calculator.checkInput() || !calculator.process() )
@@ -235,7 +235,7 @@ public boolean computeTrackFeatures( final boolean doLogIt )
235235
cancelables.clear();
236236

237237
final Logger logger = model.getLogger();
238-
final TrackFeatureCalculator calculator = new TrackFeatureCalculator( model, settings );
238+
final TrackFeatureCalculator calculator = new TrackFeatureCalculator( model, settings, doLogIt );
239239
cancelables.add( calculator );
240240
calculator.setNumThreads( numThreads );
241241
if ( calculator.checkInput() && calculator.process() )

src/main/java/fiji/plugin/trackmate/features/EdgeFeatureCalculator.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,13 @@ public class EdgeFeatureCalculator extends MultiThreadedBenchmarkAlgorithm imple
5555

5656
private String cancelReason;
5757

58-
public EdgeFeatureCalculator( final Model model, final Settings settings )
58+
private final boolean doLogIt;
59+
60+
public EdgeFeatureCalculator( final Model model, final Settings settings, final boolean doLogIt )
5961
{
6062
this.settings = settings;
6163
this.model = model;
64+
this.doLogIt = doLogIt;
6265
}
6366

6467
/*
@@ -102,7 +105,7 @@ public boolean process()
102105
}
103106

104107
// Do it.
105-
computeEdgeFeaturesAgent( model.getTrackModel().edgeSet(), settings.getEdgeAnalyzers(), true );
108+
computeEdgeFeaturesAgent( model.getTrackModel().edgeSet(), settings.getEdgeAnalyzers(), doLogIt );
106109

107110
final long end = System.currentTimeMillis();
108111
processingTime = end - start;

src/main/java/fiji/plugin/trackmate/features/ModelFeatureUpdater.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,11 @@ public class ModelFeatureUpdater implements ModelChangeListener, MultiThreaded
6666
public ModelFeatureUpdater( final Model model, final Settings settings )
6767
{
6868
this.model = model;
69-
this.spotFeatureCalculator = new SpotFeatureCalculator( model, settings );
70-
this.edgeFeatureCalculator = new EdgeFeatureCalculator( model, settings );
71-
this.trackFeatureCalculator = new TrackFeatureCalculator( model, settings );
69+
// don't log feature computation for updates.
70+
final boolean doLogIt = false;
71+
this.spotFeatureCalculator = new SpotFeatureCalculator( model, settings, doLogIt );
72+
this.edgeFeatureCalculator = new EdgeFeatureCalculator( model, settings, doLogIt );
73+
this.trackFeatureCalculator = new TrackFeatureCalculator( model, settings, doLogIt );
7274
model.addModelChangeListener( this );
7375
setNumThreads();
7476
}
@@ -81,7 +83,7 @@ public ModelFeatureUpdater( final Model model, final Settings settings )
8183
public void modelChanged( final ModelChangeEvent event )
8284
{
8385
if ( event.getEventID() != ModelChangeEvent.MODEL_MODIFIED )
84-
{ return; }
86+
return;
8587

8688
// Build spot list
8789
final ArrayList< Spot > spots = new ArrayList<>( event.getSpots().size() );

src/main/java/fiji/plugin/trackmate/features/SpotFeatureCalculator.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,13 @@ public class SpotFeatureCalculator extends MultiThreadedBenchmarkAlgorithm imple
6666

6767
private String cancelReason;
6868

69-
public SpotFeatureCalculator( final Model model, final Settings settings )
69+
private final boolean doLogIt;
70+
71+
public SpotFeatureCalculator( final Model model, final Settings settings, final boolean doLogIt )
7072
{
7173
this.settings = settings;
7274
this.model = model;
75+
this.doLogIt = doLogIt;
7376
}
7477

7578
/*
@@ -116,7 +119,7 @@ public boolean process()
116119
}
117120

118121
// Do it.
119-
computeSpotFeaturesAgent( model.getSpots(), settings.getSpotAnalyzerFactories(), true );
122+
computeSpotFeaturesAgent( model.getSpots(), settings.getSpotAnalyzerFactories(), doLogIt );
120123
return true;
121124
}
122125

@@ -149,6 +152,7 @@ private void computeSpotFeaturesAgent( final SpotCollection toCompute, final Lis
149152
final long start = System.currentTimeMillis();
150153
final Logger logger = doLogIt ? model.getLogger() : Logger.VOID_LOGGER;
151154

155+
152156
// Can't compute any spot feature without an image to compute on.
153157
if ( settings.imp == null )
154158
return;
@@ -200,6 +204,7 @@ public Void call() throws Exception
200204
if ( isCanceled() )
201205
return null;
202206

207+
203208
@SuppressWarnings( "unchecked" )
204209
final SpotAnalyzer< ? > analyzer = factory.getAnalyzer( img, frame, channel );
205210
// Fine-tune multithreading if we can.
@@ -234,6 +239,7 @@ public Void call() throws Exception
234239
executorService.shutdown();
235240
logger.setProgress( 1 );
236241
logger.setStatus( "" );
242+
237243
final long end = System.currentTimeMillis();
238244
processingTime = end - start;
239245
}

src/main/java/fiji/plugin/trackmate/features/TrackFeatureCalculator.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,13 @@ public class TrackFeatureCalculator extends MultiThreadedBenchmarkAlgorithm impl
5454

5555
private String cancelReason;
5656

57-
public TrackFeatureCalculator( final Model model, final Settings settings )
57+
private final boolean doLogIt;
58+
59+
public TrackFeatureCalculator( final Model model, final Settings settings, final boolean doLogIt )
5860
{
5961
this.settings = settings;
6062
this.model = model;
63+
this.doLogIt = doLogIt;
6164
}
6265

6366
/*
@@ -101,7 +104,7 @@ public boolean process()
101104
}
102105

103106
// Do it.
104-
computeTrackFeaturesAgent( model.getTrackModel().trackIDs( false ), settings.getTrackAnalyzers(), true );
107+
computeTrackFeaturesAgent( model.getTrackModel().trackIDs( false ), settings.getTrackAnalyzers(), doLogIt );
105108

106109
final long end = System.currentTimeMillis();
107110
processingTime = end - start;

0 commit comments

Comments
 (0)