Update-users doesn't work after git pull

[svintuss]

Hello!

I was trying to add a user to my existing Algo server and encountered that there was an issue with legacy OpenSSL Format for Apple devices which resulted in a "wrong password" error. I was forced to make a git pull and jumped from about Feb. 2022 to Sep 2024.

As a result I can't add users anymore.

1. algo.pem and algo.pem.pub are rewritten on ./algo update-users
2. ./algo update-users itself is stuck on PLAY [User management]

Here's the command output:

(.env)  ... % ./algo update-users
[WARNING]: Found variable using reserved name: no_log

PLAY [localhost] ***********************************************************************************************************************************************************

TASK [Get list of installed config files] **********************************************************************************************************************************
ok: [localhost]

TASK [Verify servers] ******************************************************************************************************************************************************
ok: [localhost] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [Build list of installed servers] *************************************************************************************************************************************
ok: [localhost]
[Server address prompt]
Select the server to update user list below: 
      1. XXX.XXX.XXX.XXX (xxx.xxx.xxx.xxx)
:

TASK [Server address prompt] ***********************************************************************************************************************************************
ok: [localhost]

TASK [Set facts based on the input] ****************************************************************************************************************************************
ok: [localhost]

TASK [Import host specific variables] **************************************************************************************************************************************
ok: [localhost]
[CA password prompt]
Enter the password for the private CA key (output is hidden):

TASK [CA password prompt] **************************************************************************************************************************************************
ok: [localhost]

TASK [Set facts based on the input] ****************************************************************************************************************************************
ok: [localhost]

--> Please include the following block of text when reporting issues:

Algo running on: macOS 12.7.6
Created from git clone. Last commit: 346437f fix: Fix server selection in update-user while preserving nice display of server along with its alt_name in the list (#14727)
Python 3.10.6
Runtime variables:
    algo_provider "digitalocean"
    algo_ondemand_cellular "True"
    algo_ondemand_wifi "True"
    algo_ondemand_wifi_exclude "c3ZpbmxpbmUsc3ZpbmxpbmVfMi41"
    algo_dns_adblocking "False"
    algo_ssh_tunneling "True"
    wireguard_enabled "True"
    dns_encryption "True"

TASK [Display the invocation environment] **********************************************************************************************************************************
changed: [localhost]

TASK [Install the requirements] ********************************************************************************************************************************************
ok: [localhost]

TASK [Generate the SSH private key] ****************************************************************************************************************************************
changed: [localhost]

TASK [Generate the SSH public key] *****************************************************************************************************************************************
changed: [localhost]

TASK [Copy the private SSH key to /tmp] ************************************************************************************************************************************
changed: [localhost]

TASK [Add the server to the vpn-host group] ********************************************************************************************************************************
changed: [localhost]

PLAY [User management] *****************************************************************************************************************************************************

Any advice would be appreciated.

[KrSw589]

Facing same issue

[tbunique]

Same problem too.

Executing ./algo update-users -vvv shows that it can't connect to the server with SSH. Of course it can't as it regenerated the algo.pem key earlier in the process.

No idea why and how to fix this issue :/

[tbunique]

So, a coworker helped me with this problem and found that if you execute the command more than once, the key is then never changed again.
He added the new public key to the authorized_keys file on the server and we could then update the users.