Handle line and column references in nonexistent_path_in_comment

Fixes #1609

Author: smoelius

examples/supplementary/nonexistent_path_in_comment/src/lib.rs

@@ -140,7 +140,7 @@ fn check_comment(cx: &LateContext<'_>, span: Span, comment_text: &str, filename:
     };
 
     for caps in PATH_REGEX.captures_iter(comment_text) {
-        let path_str = &caps[0];
+        let mut path_str = &caps[0];
 
         if path_str.chars().filter(|&c| c == '/').count() < MIN_PATH_SEPARATORS {
             continue;
@@ -150,6 +150,12 @@ fn check_comment(cx: &LateContext<'_>, span: Span, comment_text: &str, filename:
             continue;
         }
 
+        // smoelius: Strip line and column references.
+        let last_slash = path_str.rfind('/').unwrap();
+        if let Some(index) = path_str[last_slash..].find(':') {
+            path_str = &path_str[..last_slash + index];
+        }
+
         let full_path = base_dir.join(path_str);
 
         if full_path.exists() {
@@ -163,7 +169,7 @@ fn check_comment(cx: &LateContext<'_>, span: Span, comment_text: &str, filename:
         }
 
         let path_start = caps.get(0).unwrap().start();
-        let path_end = caps.get(0).unwrap().end();
+        let path_end = path_start + path_str.len();
         let path_span = Span::new(
             span.lo() + BytePos(path_start as u32),
             span.lo() + BytePos(path_end as u32),

examples/supplementary/nonexistent_path_in_comment/ui/main.rs

@@ -20,4 +20,13 @@
 // Negative test: urls
 // This is a url: https://github.com/trailofbits/dylint
 
+// Nonexistent path with line and column reference
+// See ../nonexistent/path/file.rs:1:1
+
+// Don't strip back to a colon before the last slash
+// See ../nonexistent:directory:with:colons/file.rs:1:1
+
+// Negative test: existing path with line and column reference
+// See ../src/lib.rs:1:1
+
 fn main() {}

examples/supplementary/nonexistent_path_in_comment/ui/main.stderr

@@ -15,6 +15,22 @@ LL | // The span ./ido/not/exist.rs only points to the path
    |
    = help: verify the path is correct or remove the reference
 
+warning: referenced path does not exist
+  --> $DIR/main.rs:24:8
+   |
+LL | // See ../nonexistent/path/file.rs:1:1
+   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: verify the path is correct or remove the reference
+
+warning: referenced path does not exist
+  --> $DIR/main.rs:27:8
+   |
+LL | // See ../nonexistent:directory:with:colons/file.rs:1:1
+   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: verify the path is correct or remove the reference
+
 warning: referenced path does not exist
   --> $DIR/main.rs:8:8
    |
@@ -23,5 +39,5 @@ LL |    See ../another/nonexistent/path/file.go
    |
    = help: verify the path is correct or remove the reference
 
-warning: 3 warnings emitted
+warning: 5 warnings emitted