refactor: prefer nullish decorator

Author: vladjerca

.github/workflows/ci.yml

@@ -53,7 +53,7 @@ jobs:
           deno-version: v2.3.0
 
       - name: The Sacred Assembly aka Install Dependencies
-        run: "deno task install"
+        run: 'deno task install'
 
       - name: The Scroll's Scrutiny aka Validate OpenAPI
         if: ${{

projects/api/deno.json

@@ -18,4 +18,4 @@
   "tasks": {
     "test": "deno test --unstable --allow-all"
   }
-}
+}

projects/api/src/contracts/_internal/request/bulkMediaRequestSchema.ts

@@ -7,7 +7,7 @@ import {
 } from './idsRequestSchema.ts';
 
 const watchedAtSchema = z.object({
-  watched_at: z.string().datetime().optional(),
+  watched_at: z.string().datetime().nullish(),
 });
 
 const watchWithTileAndYearSchema = z.object({
@@ -26,7 +26,7 @@ const watchWithSeasonsSchema = z
           }).merge(watchedAtSchema),
         ),
       }).merge(watchedAtSchema),
-    ).optional(),
+    ).nullish(),
   }).merge(watchedAtSchema);
 
 const addMovieToHistorySchema = z
@@ -63,8 +63,8 @@ const addEpisodeToHistorySchema = z
   }).merge(watchedAtSchema);
 
 export const bulkMediaRequestSchema = z.object({
-  movies: z.array(addMovieToHistorySchema).optional(),
-  shows: z.array(addShowToHistorySchema).optional(),
-  seasons: z.array(addSeasonToHistorySchema).optional(),
-  episodes: z.array(addEpisodeToHistorySchema).optional(),
+  movies: z.array(addMovieToHistorySchema).nullish(),
+  shows: z.array(addShowToHistorySchema).nullish(),
+  seasons: z.array(addSeasonToHistorySchema).nullish(),
+  episodes: z.array(addEpisodeToHistorySchema).nullish(),
 });

projects/api/src/contracts/_internal/request/commentsSortParamsSchema.ts

@@ -9,5 +9,5 @@ export const commentsSortParamsSchema = z.object({
     'highest',
     'lowest',
     'plays',
-  ]).optional(),
+  ]).nullish(),
 });

projects/api/src/contracts/_internal/request/extendedMediaQuerySchema.ts

@@ -1,3 +1,5 @@
 import { extendedQuerySchemaFactory } from './extendedQuerySchemaFactory.ts';
 
-export const extendedMediaQuerySchema = extendedQuerySchemaFactory<['full', 'images', 'colors', 'streaming_ids']>()
+export const extendedMediaQuerySchema = extendedQuerySchemaFactory<
+  ['full', 'images', 'colors', 'streaming_ids']
+>();

projects/api/src/contracts/_internal/request/extendedPeopleQuerySchema.ts

@@ -1,3 +1,5 @@
 import { extendedQuerySchemaFactory } from './extendedQuerySchemaFactory.ts';
 
-export const extendedPeopleQuerySchema = extendedQuerySchemaFactory<['full', 'images']>();
+export const extendedPeopleQuerySchema = extendedQuerySchemaFactory<
+  ['full', 'images']
+>();

projects/api/src/contracts/_internal/request/extendedProfileQuerySchema.ts

@@ -1,3 +1,5 @@
 import { extendedQuerySchemaFactory } from './extendedQuerySchemaFactory.ts';
 
-export const extendedProfileQuerySchema = extendedQuerySchemaFactory<['full', 'images', 'vip']>();
+export const extendedProfileQuerySchema = extendedQuerySchemaFactory<
+  ['full', 'images', 'vip']
+>();

projects/api/src/contracts/_internal/request/extendedQuerySchemaFactory.ts

@@ -5,7 +5,7 @@ export const extendedQuerySchemaFactory = <T extends string[]>() =>
   z.object({
     extended: z
       .custom<CombinationsFrom<T>>()
-      .optional()
+      .nullish()
       .openapi({
         description: 'Extended information to include in the response.',
       }),

projects/api/src/contracts/_internal/request/idsRequestSchema.ts

@@ -1,11 +1,11 @@
 import { z } from '../z.ts';
 
 const allMediaIdsSchema = z.object({
-  trakt: z.number().int().optional().openapi({ description: 'Trakt ID' }),
-  slug: z.string().optional().openapi({ description: 'Slug' }),
-  imdb: z.string().optional().openapi({ description: 'IMDb ID' }),
-  tmdb: z.number().int().optional().openapi({ description: 'TMDb ID' }),
-  tvdb: z.number().int().optional().openapi({ description: 'TVDb ID' }),
+  trakt: z.number().int().nullish().openapi({ description: 'Trakt ID' }),
+  slug: z.string().nullish().openapi({ description: 'Slug' }),
+  imdb: z.string().nullish().openapi({ description: 'IMDb ID' }),
+  tmdb: z.number().int().nullish().openapi({ description: 'TMDb ID' }),
+  tvdb: z.number().int().nullish().openapi({ description: 'TVDb ID' }),
 });
 
 const showMediaIdsSchema = allMediaIdsSchema;

projects/api/src/contracts/_internal/request/ignoreQuerySchema.ts

@@ -1,13 +1,13 @@
 import { z } from '../z.ts';
 
 export const ignoreQuerySchema = z.object({
-  ignore_watched: z.boolean().optional().openapi({
+  ignore_watched: z.boolean().nullish().openapi({
     description: 'Ignore watched items.',
   }),
-  ignore_collected: z.boolean().optional().openapi({
+  ignore_collected: z.boolean().nullish().openapi({
     description: 'Ignore collected items.',
   }),
-  ignore_watchlisted: z.boolean().optional().openapi({
+  ignore_watchlisted: z.boolean().nullish().openapi({
     description: 'Ignore watchlisted items.',
   }),
 });