refactor(utils): move asset placeholders to a dedicated file

relocates image-related constants and placeholders from the general constants utility to a dedicated assets file for better separation of concerns and improved code organization.

Author: vladjerca

projects/client/src/lib/features/image/components/CrossOriginImage.svelte

@@ -1,6 +1,6 @@
 <script lang="ts">
   import { appendClassList } from "$lib/utils/actions/appendClassList";
-  import { PLACEHOLDERS } from "$lib/utils/constants";
+  import { PLACEHOLDERS } from "$lib/utils/assets";
   import { writable } from "$lib/utils/store/WritableSubject.ts";
   import type { ImageProps } from "./ImageProps";
   import { resolveEnvironmentUri } from "./resolveEnvironmentUri";

projects/client/src/lib/requests/_internal/mapToLogo.ts

@@ -1,7 +1,7 @@
 import {
   MEDIA_COVER_LARGE_PLACEHOLDER,
   MEDIA_COVER_THUMB_PLACEHOLDER,
-} from '$lib/utils/constants.ts';
+} from '$lib/utils/assets.ts';
 import { findDefined } from '$lib/utils/string/findDefined.ts';
 import { prependHttps } from '$lib/utils/url/prependHttps.ts';
 import type { MovieResponse, ShowResponse } from '@trakt/api';

projects/client/src/lib/requests/_internal/mapToPoster.ts

@@ -1,4 +1,4 @@
-import { MEDIA_POSTER_PLACEHOLDER } from '$lib/utils/constants.ts';
+import { MEDIA_POSTER_PLACEHOLDER } from '$lib/utils/assets.ts';
 import { findDefined } from '$lib/utils/string/findDefined.ts';
 import { prependHttps } from '$lib/utils/url/prependHttps.ts';
 import type { MediaEntry } from '../models/MediaEntry.ts';

projects/client/src/lib/sections/toast/_internal/ToastEpisodeCover.svelte

@@ -5,7 +5,7 @@
   import { useEpisodeSpoilerImage } from "$lib/features/spoilers/useEpisodeSpoilerImage";
   import type { EpisodeEntry } from "$lib/requests/models/EpisodeEntry";
   import type { ShowEntry } from "$lib/requests/models/ShowEntry";
-  import { EPISODE_COVER_PLACEHOLDER } from "$lib/utils/constants";
+  import { EPISODE_COVER_PLACEHOLDER } from "$lib/utils/assets";
   import { episodeActivityTitle } from "$lib/utils/intl/episodeActivityTitle";
   import { UrlBuilder } from "$lib/utils/url/UrlBuilder";
 

projects/client/src/lib/utils/assets.ts

@@ -0,0 +1,41 @@
+import { assets } from '$app/paths';
+import { shuffle } from '$lib/utils/array/shuffle.ts';
+import { assertDefined } from './assert/assertDefined.ts';
+
+export const EPISODE_COVER_PLACEHOLDER =
+  `${assets}/placeholders/landscape_placeholder.png` as HttpsUrl;
+
+export const MEDIA_COVER_LARGE_PLACEHOLDER =
+  `${assets}/placeholders/purple_placeholder.png` as HttpsUrl;
+
+export const MEDIA_COVER_THUMB_PLACEHOLDER =
+  `${assets}/placeholders/landscape_placeholder.png` as HttpsUrl;
+
+export const MEDIA_POSTER_PLACEHOLDER =
+  `${assets}/placeholders/portrait_placeholder.png` as HttpsUrl;
+
+export const PLACEHOLDERS: string[] = [
+  EPISODE_COVER_PLACEHOLDER,
+  MEDIA_COVER_LARGE_PLACEHOLDER,
+  MEDIA_COVER_THUMB_PLACEHOLDER,
+  MEDIA_POSTER_PLACEHOLDER,
+];
+
+const generateShareCover = (type: 'show' | 'movie') =>
+  assertDefined(
+    shuffle(
+      [1, 2, 3, 4, 5].map((n) => `${assets}/trakt_share_${type}_${n}.webp`),
+    ).at(0),
+    `${type} share cover is required`,
+  );
+
+export const DEFAULT_SHARE_SHOW_COVER = generateShareCover('show');
+export const DEFAULT_SHARE_MOVIE_COVER = generateShareCover('movie');
+
+export const DEFAULT_SHARE_COVER = assertDefined(
+  shuffle([
+    DEFAULT_SHARE_SHOW_COVER,
+    DEFAULT_SHARE_MOVIE_COVER,
+  ]).at(0),
+  'Default share cover is required',
+);

projects/client/src/lib/utils/constants.ts

@@ -1,57 +1,15 @@
-import { assets } from '$app/paths';
-import { shuffle } from '$lib/utils/array/shuffle.ts';
-import { assertDefined } from './assert/assertDefined.ts';
-
 /**
  * This cover is the Alien Isolation cover.
  */
 export const DEFAULT_COVER =
   'https://walter-r2.trakt.tv/images/movies/000/759/944/fanarts/full/a12a59d031.jpg.webp';
 
-export const EPISODE_COVER_PLACEHOLDER =
-  `${assets}/placeholders/landscape_placeholder.png` as HttpsUrl;
-
-export const MEDIA_COVER_LARGE_PLACEHOLDER =
-  `${assets}/placeholders/purple_placeholder.png` as HttpsUrl;
-
-export const MEDIA_COVER_THUMB_PLACEHOLDER =
-  `${assets}/placeholders/landscape_placeholder.png` as HttpsUrl;
-
-export const MEDIA_POSTER_PLACEHOLDER =
-  `${assets}/placeholders/portrait_placeholder.png` as HttpsUrl;
-
-export const PLACEHOLDERS: string[] = [
-  EPISODE_COVER_PLACEHOLDER,
-  MEDIA_COVER_LARGE_PLACEHOLDER,
-  MEDIA_COVER_THUMB_PLACEHOLDER,
-  MEDIA_POSTER_PLACEHOLDER,
-];
-
 export const DEFAULT_AVATAR =
   'https://walter-r2.trakt.tv/hotlink-ok/placeholders/medium/zoidberg.png' as HttpsUrl;
 
 export const MAX_DATE = new Date('9999-12-31T23:59:59.999Z');
 export const MIN_DATE = new Date('0000-01-01T00:00:00.000Z');
 
-const generateShareCover = (type: 'show' | 'movie') =>
-  assertDefined(
-    shuffle(
-      [1, 2, 3, 4, 5].map((n) => `${assets}/trakt_share_${type}_${n}.webp`),
-    ).at(0),
-    `${type} share cover is required`,
-  );
-
-export const DEFAULT_SHARE_SHOW_COVER = generateShareCover('show');
-export const DEFAULT_SHARE_MOVIE_COVER = generateShareCover('movie');
-
-export const DEFAULT_SHARE_COVER = assertDefined(
-  shuffle([
-    DEFAULT_SHARE_SHOW_COVER,
-    DEFAULT_SHARE_MOVIE_COVER,
-  ]).at(0),
-  'Default share cover is required',
-);
-
 export const NOOP_FN = () => {
   // noop
 };