fix server start create buckets for juicefs

Author: deep1401

api/api.py

@@ -429,8 +429,9 @@ def _effective_storage_provider() -> str:
     """
     from lab.storage import STORAGE_PROVIDER
 
-    if STORAGE_PROVIDER == "localfs":
-        return "localfs"
+    # juicefs and localfs are always active when configured — no TFL_REMOTE_STORAGE_ENABLED gate.
+    if STORAGE_PROVIDER in ("localfs", "juicefs"):
+        return STORAGE_PROVIDER
     remote_enabled = os.getenv("TFL_REMOTE_STORAGE_ENABLED", "false").lower() == "true"
     return STORAGE_PROVIDER if remote_enabled else "localfs"
 

api/scripts/on_server_start.py

@@ -28,7 +28,11 @@ async def main() -> None:
     # Buckets/containers/local workspace dirs must exist before seed_default_experiments(),
     # which writes experiment metadata to remote storage (e.g. Azure block upload).
     tfl_remote_storage_enabled = os.getenv("TFL_REMOTE_STORAGE_ENABLED", "false").lower() == "true"
-    if tfl_remote_storage_enabled or (os.getenv("TFL_STORAGE_PROVIDER") == "localfs" and os.getenv("TFL_STORAGE_URI")):
+    if (
+        tfl_remote_storage_enabled
+        or os.getenv("TFL_STORAGE_PROVIDER") == "juicefs"
+        or (os.getenv("TFL_STORAGE_PROVIDER") == "localfs" and os.getenv("TFL_STORAGE_URI"))
+    ):
         print("✅ CHECKING STORAGE FOR EXISTING TEAMS")
         try:
             async with async_session() as session:

api/test/api/test_remote_workspace_juicefs.py

@@ -59,6 +59,7 @@ def test_validate_juicefs_config_passes_when_valid(monkeypatch, tmp_path):
 
 def test_create_juicefs_directory_creates_dir_and_sets_quota(monkeypatch, tmp_path):
     monkeypatch.setenv("TFL_JUICEFS_MOUNT_POINT", str(tmp_path))
+    monkeypatch.setenv("TFL_JUICEFS_VOLUME_NAME", "myvol")
     monkeypatch.setenv("TFL_JUICEFS_QUOTA_GB", "50")
 
     with patch("transformerlab.shared.remote_workspace.subprocess.run") as mock_run:
@@ -68,7 +69,7 @@ def test_create_juicefs_directory_creates_dir_and_sets_quota(monkeypatch, tmp_pa
     org_path = os.path.join(str(tmp_path), "orgs", "team-abc")
     assert os.path.isdir(org_path)
     mock_run.assert_called_once_with(
-        ["juicefs", "quota", "set", org_path, "--capacity", "50"],
+        ["juicefs", "quota", "set", "myvol", "--path", "/orgs/team-abc", "--capacity", "50"],
         check=True,
         capture_output=True,
         text=True,
@@ -77,6 +78,7 @@ def test_create_juicefs_directory_creates_dir_and_sets_quota(monkeypatch, tmp_pa
 
 def test_create_juicefs_directory_returns_false_on_error(monkeypatch, tmp_path):
     monkeypatch.setenv("TFL_JUICEFS_MOUNT_POINT", str(tmp_path))
+    monkeypatch.setenv("TFL_JUICEFS_VOLUME_NAME", "myvol")
     monkeypatch.setenv("TFL_JUICEFS_QUOTA_GB", "100")
 
     with patch("transformerlab.shared.remote_workspace.subprocess.run", side_effect=Exception("juicefs not found")):
@@ -87,6 +89,7 @@ def test_create_juicefs_directory_returns_false_on_error(monkeypatch, tmp_path):
 
 def test_create_bucket_for_team_routes_to_juicefs(monkeypatch, tmp_path):
     monkeypatch.setenv("TFL_JUICEFS_MOUNT_POINT", str(tmp_path))
+    monkeypatch.setenv("TFL_JUICEFS_VOLUME_NAME", "myvol")
     monkeypatch.setenv("TFL_JUICEFS_QUOTA_GB", "100")
     monkeypatch.setattr(remote_workspace, "STORAGE_PROVIDER", "juicefs", raising=False)
 

api/transformerlab/shared/remote_workspace.py

@@ -503,16 +503,21 @@ def _create_azure_container(container_name: str, team_id: str) -> bool:
 
 def _create_juicefs_directory(team_id: str) -> bool:
     mount_point = os.getenv("TFL_JUICEFS_MOUNT_POINT", "/mnt/juicefs")
+    volume_name = os.getenv("TFL_JUICEFS_VOLUME_NAME", "")
     quota_gb = int(os.getenv("TFL_JUICEFS_QUOTA_GB", "100"))
     org_path = os.path.join(mount_point, "orgs", team_id)
+    subdir_path = f"/orgs/{team_id}"
     try:
         os.makedirs(org_path, exist_ok=True)
     except OSError as e:
         print(f"❌ Failed to create JuiceFS directory {org_path}: {e}")
         return False
+    if not volume_name:
+        print("❌ TFL_JUICEFS_VOLUME_NAME is not set, cannot set JuiceFS quota")
+        return False
     try:
         subprocess.run(
-            ["juicefs", "quota", "set", org_path, "--capacity", str(quota_gb)],
+            ["juicefs", "quota", "set", volume_name, "--path", subdir_path, "--capacity", str(quota_gb)],
             check=True,
             capture_output=True,
             text=True,
@@ -549,6 +554,9 @@ async def create_buckets_for_all_teams(session, profile_name: Optional[str] = No
             print("TFL_STORAGE_PROVIDER=localfs but TFL_STORAGE_URI is not set, skipping")
             return (0, 0, ["TFL_STORAGE_URI is not set"])
         print("Initialising local workspaces for all teams (localfs mode)")
+    elif STORAGE_PROVIDER == "juicefs":
+        # juicefs doesn't require TFL_REMOTE_STORAGE_ENABLED — it's always active when configured.
+        print("Initialising JuiceFS directories for all teams")
     else:
         tfl_remote_storage_enabled = os.getenv("TFL_REMOTE_STORAGE_ENABLED", "false").lower() == "true"
         if not tfl_remote_storage_enabled:
@@ -558,8 +566,6 @@ async def create_buckets_for_all_teams(session, profile_name: Optional[str] = No
             remote_label = "GCS"
         elif STORAGE_PROVIDER == "azure":
             remote_label = "Azure"
-        elif STORAGE_PROVIDER == "juicefs":
-            remote_label = "JuiceFS"
         else:
             remote_label = "S3"
         print(f"Creating buckets for all teams using {remote_label} (TFL_STORAGE_PROVIDER={STORAGE_PROVIDER})")