Merge pull request #1867 from transformerlab/fix/admin-account-change

Allow changing admin account during cli setup

Author: deep1401

.env.example

@@ -42,6 +42,8 @@ SMTP_PASSWORD="your_email_password"
 EMAIL_FROM="your_email@example.com"
 
 ## Authentication Providers:
+# Default admin user seeded on first startup (password is always admin123 initially)
+# TLAB_DEFAULT_ADMIN_EMAIL="admin@example.com"
 EMAIL_AUTH_ENABLED="true"
 EMAIL_METHOD="dev"
 

api/transformerlab/services/experiment_init.py

@@ -16,14 +16,26 @@
 import logging
 
 logger = logging.getLogger(__name__)
+DEFAULT_ADMIN_EMAIL_ENV = "TRANSFORMERLAB_DEFAULT_ADMIN_EMAIL"
+DEFAULT_ADMIN_EMAIL_FALLBACK = "admin@example.com"
+
+
+def _get_default_admin_email() -> str:
+    configured = os.getenv(DEFAULT_ADMIN_EMAIL_ENV, "").strip()
+    if not configured:
+        return DEFAULT_ADMIN_EMAIL_FALLBACK
+    return configured
 
 
 async def seed_default_admin_user():
-    """Create a default admin user with credentials admin@example.com / admin123 if one doesn't exist."""
+    """Create a default admin user with configurable email and password admin123 if one doesn't exist."""
     try:
+        admin_email = _get_default_admin_email()
+        # Backward compatibility: avoid creating a second admin if env changes after initial seed.
+        candidate_admin_emails = {admin_email, DEFAULT_ADMIN_EMAIL_FALLBACK}
         async with AsyncSessionLocal() as session:
             # Check if admin user already exists
-            stmt = select(User).where(User.email == "admin@example.com")
+            stmt = select(User).where(User.email.in_(candidate_admin_emails))
             result = await session.execute(stmt)
             existing_admin = result.unique().scalar_one_or_none()
 
@@ -75,7 +87,7 @@ async def seed_default_admin_user():
 
             # Create admin user using UserCreate schema
             user_create = UserCreate(
-                email="admin@example.com",
+                email=admin_email,
                 password="admin123",
                 is_active=True,
                 is_superuser=True,
@@ -127,7 +139,7 @@ async def seed_default_admin_user():
             await migrate_workspace_to_org(team_id)
 
             print(
-                f"✅ Created and verified admin user admin@example.com (id={admin_user_id}, is_verified={admin_user.is_verified})"
+                f"✅ Created and verified admin user {admin_email} (id={admin_user_id}, is_verified={admin_user.is_verified})"
             )
     except Exception as e:
         print(f"⚠️  Error in seed_default_admin_user: {e}")

cli/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "transformerlab-cli"
-version = "0.0.28"
+version = "0.0.29"
 description = "Transformer Lab CLI"
 requires-python = ">=3.10"
 authors = [{ name = "Transformer Lab", email = "hello@transformerlab.ai" }]

cli/src/transformerlab_cli/commands/server.py

@@ -231,16 +231,20 @@ def _prompt_storage(existing: dict[str, str]) -> dict[str, str]:
     return env
 
 
-def _prompt_admin() -> dict[str, str]:
-    """Display admin account info. The API seeds a hardcoded admin on first startup."""
+def _prompt_admin(existing: dict[str, str]) -> dict[str, str]:
+    """Prompt for the default admin email used during first API startup."""
     console.print("\n[bold header]3. Admin Account[/bold header]")
+    default_email = existing.get("TLAB_DEFAULT_ADMIN_EMAIL", "admin@example.com")
+    admin_email = typer.prompt("Default admin email", default=default_email).strip()
+    if not admin_email:
+        admin_email = "admin@example.com"
     console.print(
         "[dim]A default admin account is created automatically on first startup:[/dim]"
-        "\n  Email:    [bold]admin@example.com[/bold]"
+        f"\n  Email:    [bold]{admin_email}[/bold]"
         "\n  Password: [bold]admin123[/bold]"
         "\n[warning]Change the default password immediately after first login![/warning]"
     )
-    return {}
+    return {"TLAB_DEFAULT_ADMIN_EMAIL": admin_email}
 
 
 def _prompt_compute(existing: dict[str, str]) -> dict[str, str]:
@@ -508,6 +512,7 @@ def _offer_install_script() -> int:
     (
         "Authentication",
         [
+            "TLAB_DEFAULT_ADMIN_EMAIL",
             "EMAIL_AUTH_ENABLED",
             "GOOGLE_OAUTH_ENABLED",
             "GOOGLE_OAUTH_CLIENT_ID",
@@ -592,11 +597,12 @@ def _write_env_file(path: str, env_vars: dict[str, str]) -> None:
 def _print_next_steps(env_vars: dict[str, str]) -> None:
     """Print post-install guidance."""
     frontend_url = env_vars.get("FRONTEND_URL", "http://localhost:8338")
+    admin_email = env_vars.get("TLAB_DEFAULT_ADMIN_EMAIL", "admin@example.com")
     console.print("\n[bold header]Next Steps[/bold header]")
     console.print("  1. Start the server:")
     console.print("     [bold]cd ~/.transformerlab/src && ./run.sh[/bold]")
     console.print(f"  2. Open {frontend_url} in your browser")
-    console.print("  3. Log in with [bold]admin@example.com[/bold] / [bold]admin123[/bold]")
+    console.print(f"  3. Log in with [bold]{admin_email}[/bold] / [bold]admin123[/bold]")
     console.print("     [warning]Change the default password immediately![/warning]")
 
 
@@ -748,7 +754,7 @@ def _install_interactive(dry_run: bool) -> None:
         provider=env_vars.get("TFL_STORAGE_PROVIDER", "unknown"),
     )
 
-    env_vars.update(_prompt_admin())
+    env_vars.update(_prompt_admin(existing))
 
     env_vars.update(_prompt_compute(existing))
     if env_vars.get("DEFAULT_COMPUTE_PROVIDER"):

cli/tests/commands/test_server.py

@@ -86,11 +86,12 @@ def test_server_install_dry_run_defaults(tmp_path):
     """Test a full dry-run with all defaults accepted."""
     fake_env = os.path.join(str(tmp_path), ".env")
 
-    # Flow: frontend URL -> storage type (aws) -> compute (skip) -> email? (n) -> auth? (n)
+    # Flow: frontend URL -> storage type (aws) -> admin email -> compute (skip) -> email? (n) -> auth? (n)
     user_input = "\n".join(
         [
             "",  # frontend URL (accept default)
             "2",  # storage type: aws
+            "",  # admin email (accept default)
             "5",  # compute: skip
             "n",  # skip email
             "n",  # skip auth
@@ -114,6 +115,7 @@ def test_server_install_writes_file(tmp_path):
         [
             "http://myserver.com:8338",  # frontend URL
             "2",  # storage type: aws
+            "owner@myserver.com",  # admin email
             "5",  # compute: skip
             "n",  # skip email
             "n",  # skip auth
@@ -132,6 +134,7 @@ def test_server_install_writes_file(tmp_path):
     assert 'FRONTEND_URL="http://myserver.com:8338"' in content
     assert 'TL_API_URL="http://myserver.com:8338/"' in content
     assert 'TFL_STORAGE_PROVIDER="aws"' in content
+    assert 'TLAB_DEFAULT_ADMIN_EMAIL="owner@myserver.com"' in content
     assert 'MULTIUSER="true"' in content
     assert "TRANSFORMERLAB_JWT_SECRET=" in content
     assert "TRANSFORMERLAB_REFRESH_SECRET=" in content
@@ -151,6 +154,7 @@ def test_server_install_preserves_jwt_secrets(tmp_path):
         [
             "",  # frontend URL (accept existing default)
             "2",  # storage: aws
+            "",  # admin email
             "5",  # compute: skip
             "n",  # skip email
             "n",  # skip auth
@@ -175,6 +179,7 @@ def test_server_install_storage_localfs(tmp_path):
             "",  # frontend URL
             "1",  # storage type: localfs
             "/mnt/shared",  # storage path
+            "",  # admin email
             "5",  # compute: skip
             "n",  # skip email
             "n",  # skip auth
@@ -198,6 +203,7 @@ def test_server_install_email_configured(tmp_path):
         [
             "",  # frontend URL
             "2",  # storage: aws
+            "",  # admin email
             "5",  # compute: skip
             "y",  # configure email
             "smtp.gmail.com",  # smtp server
@@ -225,6 +231,7 @@ def test_server_install_email_skip(tmp_path):
         [
             "",  # frontend URL
             "2",  # storage: aws
+            "",  # admin email
             "5",  # compute: skip
             "n",  # skip email
             "n",  # skip auth
@@ -246,6 +253,7 @@ def test_server_install_admin_info_displayed(tmp_path):
         [
             "",  # frontend URL
             "2",  # storage: aws
+            "owner@example.com",  # admin email
             "5",  # compute: skip
             "n",  # skip email
             "n",  # skip auth
@@ -256,7 +264,7 @@ def test_server_install_admin_info_displayed(tmp_path):
         result = runner.invoke(app, ["server", "install", "--dry-run"], input=user_input)
 
     assert result.exit_code == 0
-    assert "admin@example.com" in result.output
+    assert "owner@example.com" in result.output
     assert "admin123" in result.output
     assert "Change the default password" in result.output