Skip to content

Commit 9ede36a

Browse files
committed
dont preserve unused things
1 parent 0fb0fc9 commit 9ede36a

3 files changed

Lines changed: 11 additions & 26 deletions

File tree

api/test/shared/test_worker_leader.py

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,7 @@ def mock_lock_path(tmp_path, monkeypatch):
4141
return lock_file
4242

4343

44-
def test_try_acquire_leadership_success(reset_worker_leader_state, mock_lock_path):
45-
_ = reset_worker_leader_state
46-
_ = mock_lock_path
44+
def test_try_acquire_leadership_success():
4745
"""Test successful leadership acquisition."""
4846
import transformerlab.shared.worker_leader as wl
4947

@@ -55,9 +53,7 @@ def test_try_acquire_leadership_success(reset_worker_leader_state, mock_lock_pat
5553
mock_flock.assert_called_once()
5654

5755

58-
def test_try_acquire_leadership_already_leader(reset_worker_leader_state, mock_lock_path):
59-
_ = reset_worker_leader_state
60-
_ = mock_lock_path
56+
def test_try_acquire_leadership_already_leader():
6157
"""Test that acquiring leadership when already leader returns True immediately."""
6258
import transformerlab.shared.worker_leader as wl
6359

@@ -71,9 +67,7 @@ def test_try_acquire_leadership_already_leader(reset_worker_leader_state, mock_l
7167
mock_flock.assert_not_called()
7268

7369

74-
def test_try_acquire_leadership_failure(reset_worker_leader_state, mock_lock_path):
75-
_ = reset_worker_leader_state
76-
_ = mock_lock_path
70+
def test_try_acquire_leadership_failure():
7771
"""Test that leadership acquisition fails when lock cannot be acquired."""
7872
import transformerlab.shared.worker_leader as wl
7973

@@ -92,9 +86,7 @@ def test_try_acquire_leadership_failure(reset_worker_leader_state, mock_lock_pat
9286
mock_file.close.assert_called_once()
9387

9488

95-
def test_lock_file_created_on_success(reset_worker_leader_state, mock_lock_path):
96-
_ = reset_worker_leader_state
97-
_ = mock_lock_path
89+
def test_lock_file_created_on_success():
9890
"""Test that lock file is created when leadership is acquired."""
9991
import transformerlab.shared.worker_leader as wl
10092

@@ -113,17 +105,14 @@ def test_lock_file_created_on_success(reset_worker_leader_state, mock_lock_path)
113105
mock_file.flush.assert_called_once()
114106

115107

116-
def test_is_leader_initial_state(reset_worker_leader_state):
117-
_ = reset_worker_leader_state
108+
def test_is_leader_initial_state():
118109
"""Test that is_leader returns False initially."""
119110
import transformerlab.shared.worker_leader as wl
120111

121112
assert wl.is_leader() is False
122113

123114

124-
def test_fcntl_unavailable_fallback(reset_worker_leader_state, mock_lock_path, caplog, monkeypatch):
125-
_ = reset_worker_leader_state
126-
_ = mock_lock_path
115+
def test_fcntl_unavailable_fallback(caplog, monkeypatch):
127116
"""Test fallback behavior when fcntl is unavailable (e.g., Windows)."""
128117
import transformerlab.shared.worker_leader as wl
129118
import logging

lab-sdk/tests/test_lab_facade.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -473,8 +473,7 @@ def __init__(self, data):
473473
def __len__(self):
474474
return len(self.data)
475475

476-
def to_json(self, path_or_buf, orient, lines):
477-
_ = orient
476+
def to_json(self, path_or_buf, lines):
478477
# Handle both file-like objects and path strings (like real pandas)
479478
if hasattr(path_or_buf, "write"):
480479
# It's a file-like object
@@ -541,8 +540,7 @@ def __init__(self, data):
541540
def __len__(self):
542541
return len(self.data)
543542

544-
def to_json(self, path_or_buf, orient, lines):
545-
_ = orient
543+
def to_json(self, path_or_buf):
546544
# Handle both file-like objects and path strings (like real pandas)
547545
if hasattr(path_or_buf, "write"):
548546
# It's a file-like object
@@ -588,8 +586,7 @@ def __init__(self, data):
588586
def __len__(self):
589587
return len(self.data)
590588

591-
def to_json(self, path_or_buf, orient, lines):
592-
_ = orient
589+
def to_json(self, path_or_buf):
593590
# Handle both file-like objects and path strings (like real pandas)
594591
if hasattr(path_or_buf, "write"):
595592
# It's a file-like object
@@ -634,8 +631,7 @@ def __init__(self, data):
634631
def __len__(self):
635632
return len(self.data)
636633

637-
def to_json(self, path_or_buf, orient, lines):
638-
_ = orient
634+
def to_json(self, path_or_buf):
639635
# Handle both file-like objects and path strings (like real pandas)
640636
if hasattr(path_or_buf, "write"):
641637
# It's a file-like object

src/renderer/components/Experiment/Interactive/Interactive.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ export default function Interactive() {
823823
}
824824

825825
if (!cfg.run && !cfg.github_repo_url && !task.github_repo_url) {
826-
return { ok: false, error: 'Task is missing a command to run.' };
826+
return { ok: false, error: 'Something went wrong. Please try again.' };
827827
}
828828

829829
const payload = {

0 commit comments

Comments
 (0)