Skip to content

Commit e1c2bc0

Browse files
authored
Merge pull request #1311 from transformerlab/fix/editing-interactive-tasks
Determine the edit modal for interactive tasks correctly
2 parents 439bfb4 + ac88a7d commit e1c2bc0

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

  • src/renderer/components/Experiment/Tasks

src/renderer/components/Experiment/Tasks/Tasks.tsx

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import ViewCheckpointsModal from '../Train/ViewCheckpointsModal';
3030
import ViewEvalResultsModal from './ViewEvalResultsModal';
3131
import PreviewDatasetModal from '../../Data/PreviewDatasetModal';
3232
import ViewSweepResultsModal from './ViewSweepResultsModal';
33+
import SafeJSONParse from '../../Shared/SafeJSONParse';
3334
import NewTaskModal2 from './NewTaskModal/NewTaskModal2';
3435
import TaskYamlEditorModal from './TaskYamlEditorModal';
3536

@@ -980,7 +981,13 @@ export default function Tasks({ subtype }: { subtype?: string }) {
980981
};
981982

982983
const handleEditTask = (task: any) => {
983-
if (isInteractivePage && (task as any)?.interactive_type) {
984+
const config =
985+
typeof task?.config === 'string'
986+
? SafeJSONParse(task.config, {})
987+
: (task?.config ?? {});
988+
const isInteractive =
989+
(task as any)?.interactive_type || config?.interactive_type;
990+
if (isInteractive) {
984991
setTaskBeingEdited(task);
985992
setEditModalOpen(true);
986993
} else {
@@ -1028,8 +1035,9 @@ export default function Tasks({ subtype }: { subtype?: string }) {
10281035
/>
10291036
)}
10301037
{taskBeingEdited &&
1031-
(taskBeingEdited as any).interactive_type &&
1032-
isInteractivePage && (
1038+
((taskBeingEdited as any).interactive_type ||
1039+
SafeJSONParse((taskBeingEdited as any)?.config, {})
1040+
?.interactive_type) && (
10331041
<EditInteractiveTaskModal
10341042
open={editModalOpen}
10351043
onClose={handleEditClose}

0 commit comments

Comments
 (0)