Skip to content

Commit f530e15

Browse files
committed
fix test
1 parent fa56803 commit f530e15

2 files changed

Lines changed: 25 additions & 10 deletions

File tree

api/test/api/test_experiment_service.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ async def mock_get_experiments_dir():
2323

2424

2525
@pytest.mark.asyncio
26-
async def test_experiment_create_and_get_real(_tmp_experiments_dir):
26+
async def test_experiment_create_and_get_real(tmp_experiments_dir):
27+
_ = tmp_experiments_dir
2728
name = f"real_exp_{uuid.uuid4().hex[:8]}"
2829
cfg = {"description": "integration test experiment"}
2930
exp_id = await experiment_service.experiment_create(name, cfg)
@@ -39,14 +40,16 @@ async def test_experiment_create_and_get_real(_tmp_experiments_dir):
3940

4041

4142
@pytest.mark.asyncio
42-
async def test_missing_experiment_returns_none(_tmp_experiments_dir):
43+
async def test_missing_experiment_returns_none(tmp_experiments_dir):
44+
_ = tmp_experiments_dir
4345
# experiment_get should return None for non-existent id (FileNotFoundError handled)
4446
assert await experiment_service.experiment_get("no_such_experiment") is None
4547

4648

4749
# Added test to hit the new FileNotFoundError except-clauses in experiment_service
4850
@pytest.mark.asyncio
49-
async def test_missing_experiment_operations_handle_FileNotFound(_tmp_experiments_dir):
51+
async def test_missing_experiment_operations_handle_FileNotFound(tmp_experiments_dir):
52+
_ = tmp_experiments_dir
5053
"""
5154
Call the service functions that now catch FileNotFoundError to ensure those
5255
branches are executed and no exceptions are raised.
@@ -60,7 +63,8 @@ async def test_missing_experiment_operations_handle_FileNotFound(_tmp_experiment
6063

6164

6265
@pytest.mark.asyncio
63-
async def test_update_and_delete_flow_real(_tmp_experiments_dir):
66+
async def test_update_and_delete_flow_real(tmp_experiments_dir):
67+
_ = tmp_experiments_dir
6468
name = f"cycle_exp_{uuid.uuid4().hex[:8]}"
6569
await experiment_service.experiment_create(name, {"a": 1})
6670

api/test/shared/test_worker_leader.py

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ def mock_lock_path(tmp_path, monkeypatch):
4141
return lock_file
4242

4343

44-
def test_try_acquire_leadership_success(_reset_worker_leader_state, _mock_lock_path):
44+
def test_try_acquire_leadership_success(reset_worker_leader_state, mock_lock_path):
45+
_ = reset_worker_leader_state
46+
_ = mock_lock_path
4547
"""Test successful leadership acquisition."""
4648
import transformerlab.shared.worker_leader as wl
4749

@@ -53,7 +55,9 @@ def test_try_acquire_leadership_success(_reset_worker_leader_state, _mock_lock_p
5355
mock_flock.assert_called_once()
5456

5557

56-
def test_try_acquire_leadership_already_leader(_reset_worker_leader_state, _mock_lock_path):
58+
def test_try_acquire_leadership_already_leader(reset_worker_leader_state, mock_lock_path):
59+
_ = reset_worker_leader_state
60+
_ = mock_lock_path
5761
"""Test that acquiring leadership when already leader returns True immediately."""
5862
import transformerlab.shared.worker_leader as wl
5963

@@ -67,7 +71,9 @@ def test_try_acquire_leadership_already_leader(_reset_worker_leader_state, _mock
6771
mock_flock.assert_not_called()
6872

6973

70-
def test_try_acquire_leadership_failure(_reset_worker_leader_state, _mock_lock_path):
74+
def test_try_acquire_leadership_failure(reset_worker_leader_state, mock_lock_path):
75+
_ = reset_worker_leader_state
76+
_ = mock_lock_path
7177
"""Test that leadership acquisition fails when lock cannot be acquired."""
7278
import transformerlab.shared.worker_leader as wl
7379

@@ -86,7 +92,9 @@ def test_try_acquire_leadership_failure(_reset_worker_leader_state, _mock_lock_p
8692
mock_file.close.assert_called_once()
8793

8894

89-
def test_lock_file_created_on_success(_reset_worker_leader_state, _mock_lock_path):
95+
def test_lock_file_created_on_success(reset_worker_leader_state, mock_lock_path):
96+
_ = reset_worker_leader_state
97+
_ = mock_lock_path
9098
"""Test that lock file is created when leadership is acquired."""
9199
import transformerlab.shared.worker_leader as wl
92100

@@ -105,14 +113,17 @@ def test_lock_file_created_on_success(_reset_worker_leader_state, _mock_lock_pat
105113
mock_file.flush.assert_called_once()
106114

107115

108-
def test_is_leader_initial_state(_reset_worker_leader_state):
116+
def test_is_leader_initial_state(reset_worker_leader_state):
117+
_ = reset_worker_leader_state
109118
"""Test that is_leader returns False initially."""
110119
import transformerlab.shared.worker_leader as wl
111120

112121
assert wl.is_leader() is False
113122

114123

115-
def test_fcntl_unavailable_fallback(_reset_worker_leader_state, _mock_lock_path, caplog, monkeypatch):
124+
def test_fcntl_unavailable_fallback(reset_worker_leader_state, mock_lock_path, caplog, monkeypatch):
125+
_ = reset_worker_leader_state
126+
_ = mock_lock_path
116127
"""Test fallback behavior when fcntl is unavailable (e.g., Windows)."""
117128
import transformerlab.shared.worker_leader as wl
118129
import logging

0 commit comments

Comments
 (0)