Skip to content

Commit b274c11

Browse files
committed
Apply "_is_valid_beam_tuple" to three classes
Apply "_is_valid_beam_tuple" static private method from "DataAccessor" to three of its derived classes.
1 parent 19453ec commit b274c11

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

sourcefinder/accessors/casaimage.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ def __init__(self, url, plane=0, beam=None):
4848
self.freq_eff, self.freq_bw = self.parse_frequency(table)
4949
self.pixelsize = self.parse_pixelsize()
5050

51-
if not self.beam or beam:
51+
if self._is_valid_beam_tuple(beam) or not self._is_valid_beam_tuple(
52+
self.beam):
5253
# An argument-supplied beam overrides a beam derived from
5354
# (bmaj, bmin, bpa) in a config.toml. Only if those two options
5455
# are not specified, we parse the beam from the header.
55-
bmaj, bmin, bpa = beam if beam else self.parse_beam(table)
56+
bmaj, bmin, bpa = beam if self._is_valid_beam_tuple(beam) else (
57+
self.parse_beam(table))
5658
self.beam = self.degrees2pixels(
5759
bmaj, bmin, bpa, self.pixelsize[0], self.pixelsize[1]
5860
)

sourcefinder/accessors/fitsimage.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,13 @@ def __init__(self, url, plane=None, beam=None, hdu_index=0):
4343
self.freq_eff, self.freq_bw = self.parse_frequency()
4444
self.pixelsize = self.parse_pixelsize()
4545

46-
if not self.beam or beam:
46+
if self._is_valid_beam_tuple(beam) or not self._is_valid_beam_tuple(
47+
self.beam):
4748
# An argument-supplied beam overrides a beam derived from
4849
# (bmaj, bmin, bpa) in a config.toml. Only if those two options
4950
# are not specified, we parse the beam from the header.
50-
bmaj, bmin, bpa = beam if beam else self.parse_beam()
51+
bmaj, bmin, bpa = beam if self._is_valid_beam_tuple(beam) else (
52+
self.parse_beam())
5153
self.beam = self.degrees2pixels(
5254
bmaj, bmin, bpa, self.pixelsize[0], self.pixelsize[1]
5355
)

sourcefinder/accessors/fitsimageblob.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,13 @@ def __init__(self, hdulist, plane=None, beam=None, hdu_index=0):
4040
self.freq_eff, self.freq_bw
4141
self.url = "_".join([str(x) for x in elements])
4242

43-
if not self.beam or beam:
43+
if self._is_valid_beam_tuple(beam) or not self._is_valid_beam_tuple(
44+
self.beam):
4445
# An argument-supplied beam overrides a beam derived from
4546
# (bmaj, bmin, bpa) in a config.toml. Only if those two options
4647
# are not specified, we parse the beam from the header.
47-
bmaj, bmin, bpa = beam if beam else self.parse_beam()
48+
bmaj, bmin, bpa = beam if self._is_valid_beam_tuple(beam) else (
49+
self.parse_beam())
4850
self.beam = self.degrees2pixels(
4951
bmaj, bmin, bpa, self.pixelsize[0], self.pixelsize[1]
5052
)

0 commit comments

Comments
 (0)