Add knip checks #274
Merged
Add knip checks #274
+620
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mifi
reviewed
Dec 30, 2025
Collaborator
mifi
left a comment
mifi
left a comment
There was a problem hiding this comment.
cool stuff. should we add it to uppy also or wdyt?
| "p-queue": "^9.0.1", | ||
| "recursive-readdir": "^2.2.3", | ||
| "tus-js-client": "^4.3.1", | ||
| "typanion": "^3.14.0", |
Collaborator
There was a problem hiding this comment.
ironically, this seems unused. and shouldn't that have been caught by knip?
Member
Author
There was a problem hiding this comment.
Typanion is a peer dependency of clipanion. node_modules/clipanion/package.json lists "typanion": "*" in peerDependencies and also lists it in its own dependencies. That’s why it should remain in node-sdk/package.json even without direct imports.
Knip doesn’t flag it because it treats peer‑required deps as needed (or because clipanion’s peer requirement effectively justifies it).
Member
Author
Yes i think so, still making some tweaks tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs opened: