Skip to content

Commit a585c9f

Browse files
authored
fix review issues (#19)
1 parent 4e3874b commit a585c9f

3 files changed

Lines changed: 5 additions & 8 deletions

File tree

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"id": "atmosphere",
33
"name": "Atmosphere",
4-
"version": "0.1.12",
4+
"version": "0.1.13",
55
"minAppVersion": "0.15.0",
66
"description": "Various integrations with AT Protocol.",
77
"author": "treethought",

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "obsidian-atmosphere",
3-
"version": "0.1.12",
3+
"version": "0.1.13",
44
"description": "Various integrations with AT Protocol.",
55
"main": "main.js",
66
"type": "module",

src/views/standardfeed.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class StandardFeedView extends ItemView {
5353
for (const uri of pubUris) {
5454
try {
5555
const pub = await getPublication(this.plugin.client, uri);
56-
void this.renderPublicationCard(list, pub);
56+
this.renderPublicationCard(list, pub);
5757
} catch (e) {
5858
console.warn(`Failed to fetch publication at ${uri}:`, e);
5959
}
@@ -68,7 +68,7 @@ export class StandardFeedView extends ItemView {
6868
}
6969
}
7070

71-
private async renderPublicationCard(container: HTMLElement, pub: ATRecord<Publication>) {
71+
private renderPublicationCard(container: HTMLElement, pub: ATRecord<Publication>) {
7272
const card = container.createEl("div", { cls: "standard-site-publication" });
7373

7474
const header = card.createEl("div", { cls: "standard-site-publication-header" });
@@ -136,11 +136,8 @@ export class StandardFeedView extends ItemView {
136136

137137
const parsed = parseResourceUri(pub.uri);
138138
if (!parsed.ok) {
139-
// URI is an acronym
140-
// eslint-disable-next-line obsidianmd/ui/sentence-case
141-
container.createEl("p", { text: "Failed to parse publication URI." });
139+
container.createEl("p", { text: "Failed to parse publication address." });
142140
console.error("Failed to parse publication URI:", parsed.error);
143-
144141
return;
145142
}
146143

0 commit comments

Comments
 (0)