Show warning message about lakectl local performance (#10374)

Author: idanovo

cmd/lakectl/cmd/common_helpers.go

@@ -34,7 +34,7 @@ const (
 	LakectlInteractive     = "LAKECTL_INTERACTIVE"
 	DeathMessage           = "{{.Error|red}}\nError executing command.\n"
 	DeathMessageWithFields = "{{.Message|red}}\n{{.Status}}\n"
-	WarnMessage            = "{{.Warning|yellow}}\n\n"
+	WarnMessage            = "{{.Prefix|yellow}} {{.Message}}\n\n"
 )
 
 const (
@@ -234,7 +234,7 @@ func WriteIfVerbose(tpl string, data any) {
 }
 
 func Warning(message string) {
-	WriteTo(WarnMessage, struct{ Warning string }{Warning: "Warning: " + message}, os.Stderr)
+	WriteTo(WarnMessage, struct{ Prefix, Message string }{Prefix: "Warning:", Message: message}, os.Stderr)
 }
 
 func Die(errMsg string, code int) {

cmd/lakectl/cmd/local.go

@@ -32,6 +32,8 @@ const (
 	cloneOperation    LocalOperation = "clone"
 
 	CaseInsensitiveWarningMessageFormat = `Directory '%s' is case-insensitive, versioning tools such as lakectl local and git will work incorrectly.`
+
+	localScalabilityWarning = `Using "lakectl local" requires a full local copy of cloned data. For a more scalable solution, please refer to: https://docs.lakefs.io/reference/mount.html`
 )
 
 const localSummaryTemplate = `
@@ -157,6 +159,7 @@ var localCmd = &cobra.Command{
 	Short: "Sync local directories with lakeFS paths",
 	PersistentPreRun: func(cmd *cobra.Command, args []string) {
 		preRunCmd(cmd)
+		Warning(localScalabilityWarning)
 
 		_, localPath := getSyncArgs(args, false, false)
 		cmdSuffix := ""

esti/lakectl_util.go

@@ -39,6 +39,7 @@ var (
 	rePreSignURL      = regexp.MustCompile(`https?://\S+\?\S+`)
 	reSecretAccessKey = regexp.MustCompile(`secret_access_key: \S{16,128}`)
 	reAccessKeyID     = regexp.MustCompile(`access_key_id: AKIA\S{12,124}`)
+	reLocalWarning    = regexp.MustCompile(`(?m)^Warning: Using "lakectl local" requires .*\n\n?`)
 )
 
 func lakeBinaryLocation(name string) string {
@@ -149,6 +150,7 @@ func sanitize(output string, vars map[string]string) string {
 	// The order of execution below is important as certain expression can contain others
 	// and so, should be handled first
 	s := strings.ReplaceAll(output, "\r\n", "\n")
+	s = reLocalWarning.ReplaceAllString(s, "")
 	if _, ok := vars["DATE"]; !ok {
 		s = normalizeProgramTimestamp(s)
 	}