Conversation
The extendable/ plugin system existed to allow Enterprise builds to override Community defaults. In the Community build this indirection serves no purpose — every plugin just delegates to a concrete implementation. Remove the entire plugin layer (17 files) and inline default behavior directly into consumer components. - Delete webui/src/extendable/ directory (plugin interfaces, manager, context, and all default implementations) - Inline RepositoryCreateForm, commits.commit(), refs.merge(), CompareBranches, and TablesEnterpriseInfo directly - Remove SSO login strategy (not supported in Community) - Remove custom object renderers plugin check (was always null) https://claude.ai/code/session_01WvCiwezBCR1HkkeY1gSQff
|
|
nopcoder
added
the
exclude-changelog
itaigilo
left a comment
itaigilo
left a comment
There was a problem hiding this comment.
LGTM,
with some small comments.
Main thing is -
Do we still want to keep the Tables tab, or should we remove it?
| @@ -1552,7 +1546,7 @@ const ObjectsBrowser = ({ storageConfig, capabilitiesConfig }) => { | |||
| }} | |||
| > | |||
| {dataView === DATA_VIEW_TABLES ? ( | |||
There was a problem hiding this comment.
Do we want to keep the Tables tab?
| const TablesActions = pluginManager.tablesBrowser.getTablesActionsComponent(); | ||
| return TablesActions ? <TablesActions /> : null; | ||
| })()} | ||
| {/* Tables view has no additional actions in Community edition */} |
There was a problem hiding this comment.
I think this comment can be removed.
There was a problem hiding this comment.
CapabilitiesConfig is still exported but is no longer imported anywhere after the deletion.
There was a problem hiding this comment.
Good point. Removing.
| const TablesView = ({ pluginManager }) => { | ||
| const TablesComponent = pluginManager.tablesBrowser.getTablesBrowserComponent(); | ||
| return <TablesComponent />; | ||
| const TablesView = () => { |
There was a problem hiding this comment.
No need for this function now, can just use TablesEnterpriseInfo.
4 participants
Drop the webui plugin system existed and embed the default behaviour.
Closes https://github.com/treeverse/lakeFS-Enterprise/issues/1953