compspec-seed-data-change #1313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rssk
reviewed
May 9, 2022
| path: '/api', | ||
| }; | ||
|
|
||
| // const config = { |
|
|
||
| axios.defaults.baseURL = `${config.protocol}://${config.apiServer}:${config.port}${config.path}`; | ||
|
|
||
| const query = 'query fetchAllComputations($preprocess: Boolean) {fetchAllComputations(preprocess: $preprocess) {id, computation {type, dockerImage, command, input}, meta { id,name,preprocess }}}'; |
| async function getComputations() { | ||
| const computationsFromApi = await fetchAllComputations(); | ||
| const computationsFromSeedData = await getComputationsFromSeedData(); | ||
| return [...computationsFromApi, ...computationsFromSeedData]; |
Contributor
There was a problem hiding this comment.
add comment about merging comps
Contributor
There was a problem hiding this comment.
might be simpler to dedupe here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
closes _issue API: revise compspec seed data usage #1303
What is the new behavior (if this is a feature change)?
There are now public routes in the api.
the devdata script now populates the local dev database with computations pulled from the production api.
If
.jsonfiles are present inpackages\coinstac-api-server\seed\datathose compspecs will override the ones pulled from the api.