wip: adding dipose to the repository storage

Author: vojtatranta

suite-common/suite-sync-storage/src/SuiteSyncStorageRepository.ts

@@ -26,6 +26,7 @@ export type CreateSuiteSyncStorageRepositoryFactoryDeps = CreateSuiteStorageDep
 export type SuiteSyncStorageRepository = {
     get: (owner: SuiteSyncOwner) => SuiteSyncStorage;
     delete: (ownerId: SuiteSyncOwnerId) => Promise<void>;
+    deleteAll: () => Promise<void>;
 };
 
 export type CreateSuiteSyncStorageRepository = () => SuiteSyncStorageRepository;
@@ -62,5 +63,10 @@ export const createSuiteSyncStorageRepositoryFactory =
                 await storages.get(suiteSyncOwner)?.dispose();
                 storages.delete(suiteSyncOwner);
             },
+
+            deleteAll: async () => {
+                await Promise.all(Array.from(storages.values()).map(storage => storage.dispose()));
+                storages.clear();
+            },
         };
     };

suite-common/suite-sync-storage/tests/SuiteSyncStorageRepository.test.ts

@@ -4,6 +4,7 @@ import {
     asSuiteSyncOwnerSecretHex,
 } from '@suite-common/suite-types';
 
+import { SuiteSyncStorage } from '../src';
 import {
     CreateSuiteStorage,
     createSuiteSyncStorageRepositoryFactory,
@@ -31,4 +32,117 @@ describe('SuiteSyncStorageRepository', () => {
             suiteSyncOwner: owner,
         });
     });
+
+    it('stores only one storage per owner', () => {
+        const mockStorage = {
+            dispose: jest.fn(),
+            updateRelayUrl: jest.fn(),
+        } as unknown as SuiteSyncStorage;
+        const createSuiteStorage: CreateSuiteStorage = jest.fn().mockReturnValue(mockStorage);
+
+        const repository = createSuiteSyncStorageRepositoryFactory({
+            createSuiteStorage,
+            getRelayUrl: () => '',
+            defaultRelayUrl: 'http://default-relay.trezor.io',
+        })();
+
+        repository.get(owner);
+        repository.get(owner);
+
+        expect(createSuiteStorage).toHaveBeenCalledTimes(1);
+    });
+
+    it('deletes and owner instance and creates a new one', async () => {
+        const mockStorage = {
+            dispose: jest.fn(),
+            updateRelayUrl: jest.fn(),
+        } as unknown as SuiteSyncStorage;
+
+        const createSuiteStorage: CreateSuiteStorage = jest.fn().mockReturnValue(mockStorage);
+
+        const repository = createSuiteSyncStorageRepositoryFactory({
+            createSuiteStorage,
+            getRelayUrl: () => '',
+            defaultRelayUrl: 'http://default-relay.trezor.io',
+        })();
+
+        repository.get(owner);
+        await repository.delete(owner.ownerId);
+        repository.get(owner);
+
+        expect(createSuiteStorage).toHaveBeenCalledTimes(2);
+    });
+
+    it('deletes all storages', async () => {
+        const owner2: SuiteSyncOwner = {
+            ownerSecret: asSuiteSyncOwnerSecretHex('Secret1235'),
+            ownerId: asSuiteSyncOwnerId('Owner1235'),
+        };
+        const mockStorage1 = {
+            id: '1',
+            dispose: jest.fn(),
+            updateRelayUrl: jest.fn(),
+        } as unknown as SuiteSyncStorage;
+
+        const mockStorage2 = {
+            id: '2',
+            dispose: jest.fn(),
+            updateRelayUrl: jest.fn(),
+        } as unknown as SuiteSyncStorage;
+
+        const createSuiteStorage: CreateSuiteStorage = jest
+            .fn()
+            .mockReturnValueOnce(mockStorage1)
+            .mockReturnValueOnce(mockStorage2);
+
+        const repository = createSuiteSyncStorageRepositoryFactory({
+            createSuiteStorage,
+            getRelayUrl: () => '',
+            defaultRelayUrl: 'http://default-relay.trezor.io',
+        })();
+
+        repository.get(owner);
+        repository.get(owner2);
+        await repository.deleteAll();
+
+        expect(mockStorage1.dispose).toHaveBeenCalledTimes(1);
+        expect(mockStorage2.dispose).toHaveBeenCalledTimes(1);
+    });
+
+    it('clears all storages in memory after deleteAll', async () => {
+        const owner2: SuiteSyncOwner = {
+            ownerSecret: asSuiteSyncOwnerSecretHex('Secret1235'),
+            ownerId: asSuiteSyncOwnerId('Owner1235'),
+        };
+        const mockStorage1 = {
+            id: '1',
+            dispose: jest.fn(),
+            updateRelayUrl: jest.fn(),
+        } as unknown as SuiteSyncStorage;
+
+        const mockStorage2 = {
+            id: '2',
+            dispose: jest.fn(),
+            updateRelayUrl: jest.fn(),
+        } as unknown as SuiteSyncStorage;
+
+        const createSuiteStorage: CreateSuiteStorage = jest
+            .fn()
+            .mockReturnValueOnce(mockStorage1)
+            .mockReturnValueOnce(mockStorage2);
+
+        const repository = createSuiteSyncStorageRepositoryFactory({
+            createSuiteStorage,
+            getRelayUrl: () => '',
+            defaultRelayUrl: 'http://default-relay.trezor.io',
+        })();
+
+        repository.get(owner);
+        repository.get(owner2);
+        await repository.deleteAll();
+        repository.get(owner);
+        repository.get(owner2);
+
+        expect(createSuiteStorage).toHaveBeenCalledTimes(4);
+    });
 });

suite-common/suite-sync/src/turnOffSuiteSync.ts

@@ -1,6 +1,10 @@
 import type { Dispatch } from '@reduxjs/toolkit';
 
-import { TurnOffSuiteSync, UnsubscribeSuiteSyncStorage } from '@suite-common/suite-sync-storage';
+import {
+    SuiteSyncStorageRepository,
+    TurnOffSuiteSync,
+    UnsubscribeSuiteSyncStorage,
+} from '@suite-common/suite-sync-storage';
 import { selectDevices } from '@suite-common/wallet-core';
 import { isTrezorDeviceWithState } from '@suite-common/wallet-utils';
 
@@ -10,6 +14,7 @@ type CreateTurnOffSuiteSyncDeps = {
     getState: () => any;
     dispatch: Dispatch;
     unsubscribeSuiteSyncStorage: UnsubscribeSuiteSyncStorage;
+    suiteSyncStorageRepository: SuiteSyncStorageRepository;
 };
 
 export const createTurnOffSuiteSync =
@@ -32,4 +37,6 @@ export const createTurnOffSuiteSync =
                 .filter(isTrezorDeviceWithState)
                 .map(device => deps.unsubscribeSuiteSyncStorage({ device })),
         );
+
+        await deps.suiteSyncStorageRepository.deleteAll();
     };