refactor(trading): move getRandomAccountDescriptor to suite-common

Extract getRandomAccountDescriptor into @suite-common/trading as the single
source and have both web (TRADING_FALLBACK_API_KEY) and native consume it,
replacing the duplicated native-only helper.

Author: sherpaPSX

suite-common/trading/src/constants.ts

@@ -1,7 +1,8 @@
 import { type SellFiatFlowType } from 'invity-api';
 
 import { type NetworkSymbol, type NetworkType } from '@suite-common/wallet-config';
-import { getWeakRandomId } from '@trezor/utils';
+
+import { getRandomAccountDescriptor } from './utils/apiKeyUtils';
 
 export const TRADING_PREFIX = '@trading';
 export const TRADING_EXTENDED_PREFIX = `${TRADING_PREFIX}-extended`;
@@ -74,7 +75,7 @@ export const SLIPPAGE_MIN = '0.01';
 export const SLIPPAGE_MAX = '50';
 export const SLIPPAGE_PRESETS = ['0.1', '0.5', '1', '3'];
 export const INVITY_API_RELOAD_DATA_AFTER_MS = 10 * 60 * 1000; // 10 minutes
-export const TRADING_FALLBACK_API_KEY = getWeakRandomId(20);
+export const TRADING_FALLBACK_API_KEY = getRandomAccountDescriptor();
 export const INVITY_API_RELOAD_QUOTES_AFTER_SECONDS = 30;
 
 export const CRYPTO_PLATFORM_SEPARATOR = '--';

suite-common/trading/src/index.ts

@@ -36,6 +36,7 @@ export * from './hooks/useTradingDetail';
 export type * from './types/tradingDetail';
 export type * from './types';
 export * from './utils';
+export * from './utils/apiKeyUtils';
 export * from './utils/tradingAccountUtils';
 export * from './utils/buy/buyUtils';
 export * from './utils/receiveAccountUtils';

suite-common/trading/src/utils/__tests__/apiKeyUtils.test.ts

@@ -0,0 +1,11 @@
+import { getRandomAccountDescriptor } from '../apiKeyUtils';
+
+describe('getRandomAccountDescriptor', () => {
+    it('should return 20 characters', () => {
+        expect(getRandomAccountDescriptor().length).toBe(20);
+    });
+
+    it('should return different string on every call', () => {
+        expect(getRandomAccountDescriptor()).not.toBe(getRandomAccountDescriptor());
+    });
+});

suite-common/trading/src/utils/apiKeyUtils.ts

@@ -0,0 +1,3 @@
+import { getWeakRandomId } from '@trezor/utils';
+
+export const getRandomAccountDescriptor = () => getWeakRandomId(20);

suite-native/module-trading/src/hooks/buy/__tests__/useBuyData.test.tsx

@@ -16,8 +16,8 @@ import { tradingSlice } from '@suite-native/trading-state';
 
 import { useBuyData } from '../useBuyData';
 
-jest.mock('@suite-native/trading-quote-utils', () => ({
-    ...jest.requireActual('@suite-native/trading-quote-utils'),
+jest.mock('@suite-common/trading', () => ({
+    ...jest.requireActual('@suite-common/trading'),
     getRandomAccountDescriptor: () => 'random_string',
 }));
 

suite-native/module-trading/src/hooks/buy/useBuyData.ts

@@ -1,8 +1,11 @@
 import { useEffect } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 
-import { selectTradingBuyLoadingTimestampAndStatus, tradingThunks } from '@suite-common/trading';
-import { getRandomAccountDescriptor } from '@suite-native/trading-quote-utils';
+import {
+    getRandomAccountDescriptor,
+    selectTradingBuyLoadingTimestampAndStatus,
+    tradingThunks,
+} from '@suite-common/trading';
 import { selectBuySelectedReceiveAccount } from '@suite-native/trading-state';
 
 export const useBuyData = (reloadRequestOrdinal: number) => {

suite-native/module-trading/src/hooks/exchange/__tests__/useExchangeData.test.ts

@@ -6,8 +6,8 @@ import { getBtcAccount, getInitializedTradingState } from '@suite-native/trading
 import { createTradingLightStore } from '../../../__tests__/tradingTestUtils';
 import { useExchangeData } from '../useExchangeData';
 
-jest.mock('@suite-native/trading-quote-utils', () => ({
-    ...jest.requireActual('@suite-native/trading-quote-utils'),
+jest.mock('@suite-common/trading', () => ({
+    ...jest.requireActual('@suite-common/trading'),
     getRandomAccountDescriptor: () => 'random_string',
 }));
 

suite-native/module-trading/src/hooks/exchange/useExchangeData.ts

@@ -2,10 +2,10 @@ import { useEffect } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 
 import {
+    getRandomAccountDescriptor,
     selectTradingExchangeLoadingTimestampAndStatus,
     tradingThunks,
 } from '@suite-common/trading';
-import { getRandomAccountDescriptor } from '@suite-native/trading-quote-utils';
 import { selectExchangeSelectedSendAccount } from '@suite-native/trading-state';
 
 export const useExchangeData = (reloadRequestOrdinal: number) => {

suite-native/module-trading/src/hooks/sell/__tests__/useSellData.test.tsx

@@ -6,8 +6,8 @@ import { getBtcAccount, getInitializedTradingState } from '@suite-native/trading
 import { createTradingLightStore } from '../../../__tests__/tradingTestUtils';
 import { useSellData } from '../useSellData';
 
-jest.mock('@suite-native/trading-quote-utils', () => ({
-    ...jest.requireActual('@suite-native/trading-quote-utils'),
+jest.mock('@suite-common/trading', () => ({
+    ...jest.requireActual('@suite-common/trading'),
     getRandomAccountDescriptor: () => 'random_string',
 }));
 

suite-native/module-trading/src/hooks/sell/useSellData.ts

@@ -1,8 +1,11 @@
 import { useEffect } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 
-import { selectTradingSellLoadingTimestampAndStatus, tradingThunks } from '@suite-common/trading';
-import { getRandomAccountDescriptor } from '@suite-native/trading-quote-utils';
+import {
+    getRandomAccountDescriptor,
+    selectTradingSellLoadingTimestampAndStatus,
+    tradingThunks,
+} from '@suite-common/trading';
 import { selectSellSelectedSendAccount } from '@suite-native/trading-state';
 
 export const useSellData = (reloadRequestOrdinal: number) => {