Runtime typedCall: Device not initialized when calling GetPublicKey. call Initialize first

[sentry]

Account discovery runs even for outdated firmware requiring update.

Sentry Issue: TREZOR-SUITE-16R4

Runtime typedCall: Device not initialized when calling GetPublicKey. call Initialize first

[marekrjpolak]

The issue emerged in #18821.

When running T1 with old 1.8.0 fw, it's firmwareStatus is outdated (while previously it was required), so it runs discovery when it shouldn't. So basically required status now doesn't work properly.

a) Are we able to fix the status with the new releases approach (= required whenever there is a required fw version between current and advertised version)?

b) Why is there required: false e.g. in t1b1-1.9.0-universal.json

trezor-suite/packages/connect-common/files/firmware/t1b1/universal/t1b1-1.9.0-universal.json

Lines 2 to 3 in 0c16c5f

	"required": false,
	"version": [1, 9, 0],

while there was required: true in old releases.json at [1,9,0] version

trezor-suite/packages/connect-common/files/firmware/t1b1/releases.json

Lines 198 to 199 in 0c16c5f

	"required": true,
	"version": [1, 9, 0],

? I mean, it's not enough to change the file to fix the issue, but I wonder anyway.

Cc: @karliatto

[karliatto]

@marekrjpolak the reason is that we changed to use data.trezor.io as single source of truth, before apparently some changes were made in releases.json files in Suite but they were not in the original data.trezor.io https://github.com/trezor/data/blob/master/firmware/t1b1/releases.json#L243

And yes the logic to isRequired is in the current implementation https://github.com/trezor/trezor-suite/blob/develop/packages/connect/src/data/firmwareInfo.ts#L533

And in here it sets the device firmwareStatus to required https://github.com/trezor/trezor-suite/blob/develop/packages/connect/src/data/firmwareInfo.ts#L533

So in order to make it work we need to update data.trezor.io and the new bundled releases JSON, so we will have a trusted source of truth.

[karliatto]

@marekrjpolak this should fix the isRequired from changelog releases #22135 and also add the missing required:true in the new releases JSON files.

[karliatto]

Changes in trezor/data trezor/data#150