[TC] merge Question.

[Krutok]

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

• I understand that my issue may get closed without notice if I intentionally remove or skip any mandatory* field
• This is NOT a bug/crash report
• I've searched the bugtracker for similar questions/requests including closed ones

Description

I wanted to ask what the update interval is now. When you release a new NPCBOT patch, will it also be available in your TC fork immediately or with a week delay?

And how many days weeks ago is your fork compared to TC?
I ask because I may plan to take the fork from here again, which then already contains the patch.

TrinityCore or AzerothCore

TrinityCore

Core rev. hash/commit

No response

Operating system

Debian 11

[trickerer]

As of today (22 Aug 2023) TC+NPCBots repository is up-to-date with TC base 3.3.5 from 20 Aug 2023 (TrinityCore/TrinityCore@1bea4aa)

Each Saturday changes get pulled from upstream (base TC 3.3.5 branch), if merge is successfull then new patch is released the same day, this never changed. Patches get updated using the forks, not vice versa.

Last update was delayed because of major changes made in TC 3.3.5 branch, it took some time to go through bots code and update it.

Also worth mentioning that building TC on Windows now requires Visual Studio 2022 which I don't have on my dev machine currently, so future updates my get delayed if they don't succeed via automerge. But really I don't think there is much to worry about - 3.3.5 TC branch doesn't receive frequent updates anyway.

[Krutok]

Thank you for your detailed reply.

[Krutok]

So your repo hasn't been updated for 2 weeks, although an automatic merge would be possible. And you can't start a PR to start the update process.

I have now set up my own fork with the last npcbot patch and have installed the last TC update. Everything is compatible, but nothing happens automatically here, although it would be possible.

It's a shame actually.

[trickerer]

Well I have no idea why PRs are limited to collaborators, google says GH in some emergency state or something. I don't have any temporary restrictions enabled.

TC automatic merge was failing because I forgot to update automerge repository. Merge is completed now trickerer/TrinityCore-3.3.5-with-NPCBots@a605960.
I'm not updating the patch since I can't run it myself to check if it actually works and won't bug out with basic functionality or even crash at startup.

[Krutok]

Well I have no idea why PRs are limited to collaborators, google says GH in some emergency state or something. I don't have any temporary restrictions enabled.

TC automatic merge was failing because I forgot to update automerge repository. Merge is completed now trickerer/TrinityCore-3.3.5-with-NPCBots@a605960. I'm not updating the patch since I can't run it myself to check if it actually works and won't bug out with basic functionality or even crash at startup.

That's why I wanted to help and start a PR, but unfortunately it didn't work.

[Krutok]

Is the project dead because there hasn't been an update for months?

[Krutok]

It would be very nice if people would comment on whether updates will appear, because the patch is currently no longer compatible with the TC Core

[trickerer]

trickerer/TrinityCore-3.3.5-with-NPCBots@9e551a9
Not tested.