-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests assume daemon is uid 1 #708
Comments
Oh, that's because those tests are run on CI only where uid 1 will be daemon. We could disable those for local runs using the |
Ok the |
Go ahead, if you want to discuss your solution before shooting it in as a PR feel free to do that here. |
Currently my preferred solution is to mark any tests that might fail on a local system with Here's an example run of cargo test: Example run of cargo test
EDIT: And a link to a codecov report: |
This is an error that I get when I run cargo test.
Is there any reason that sudo-rs requires the daemon user be uid 1?
Edit:
Here is the link to the relavent test:
https://github.com/memorysafety/sudo-rs/blob/8ef8e70f91df792713eebb59284158561b4b339f/src/system/mod.rs#L661-L673
System
Here is the top of my /etc/passwd:
Here is the /etc/group greped for daemon:
I am currently running a 13 inch M1 Macbook pro running asahi linux (Arch linux ARM).
The text was updated successfully, but these errors were encountered: