Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std::os::unix::fs::fchown #755

Open
japaric opened this issue Sep 5, 2023 · 3 comments
Open

use std::os::unix::fs::fchown #755

japaric opened this issue Sep 5, 2023 · 3 comments
Labels

Comments

@japaric
Copy link
Collaborator

japaric commented Sep 5, 2023

instead of the unsafe libc::fchown. this API will be stabilized in Rust 1.73 (~ 2023-10-05)

https://github.com/memorysafety/sudo-rs/blob/9b9a7e428240930d213723ca39be16752c7d5e02/src/system/file/chown.rs#L16

@rnijveld
Copy link
Collaborator

rnijveld commented Sep 5, 2023

I would suggest we only do this once our MSRV increases past this version some time in the future, and not increase our MSRV just because of this feature.

@squell
Copy link
Member

squell commented Sep 5, 2023

Maybe we can introduce some labels for issues that have to wait only because of a MSRV-related issue?

@pvdrz
Copy link
Collaborator

pvdrz commented Sep 6, 2023

@squell maybe we could do milestones for these so we can actually track the specific version for each issue, what do you think?

@squell squell added the msrv label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants