Merge pull request #1115

iakov · iakov · commit 261bcc418204 · 2020-09-24T11:36:59.000+03:00
Fix crash with balls/skittles memory access
diff --git a/plugins/robots/common/twoDModel/src/engine/model/physics/box2DPhysicsEngine.cpp b/plugins/robots/common/twoDModel/src/engine/model/physics/box2DPhysicsEngine.cpp
@@ -59,7 +59,7 @@ Box2DPhysicsEngine::Box2DPhysicsEngine (const WorldModel &worldModel
 	connect(&worldModel, &model::WorldModel::ballAdded,
 			this, [this](const QSharedPointer<QGraphicsItem> &i) {itemAdded(i.data());});
 	connect(&worldModel, &model::WorldModel::itemRemoved,
-			this, [this](const QSharedPointer<QGraphicsItem> &i) {itemAdded(i.data());});
+			this, [this](const QSharedPointer<QGraphicsItem> &i) {itemRemoved(i.data());});
 }
 
 Box2DPhysicsEngine::~Box2DPhysicsEngine(){

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ Box2DPhysicsEngine::Box2DPhysicsEngine (const WorldModel &worldModel`
`59`	`59`	`connect(&worldModel, &model::WorldModel::ballAdded,`
`60`	`60`	`this, [this](const QSharedPointer<QGraphicsItem> &i) {itemAdded(i.data());});`
`61`	`61`	`connect(&worldModel, &model::WorldModel::itemRemoved,`
`62`		`- this, [this](const QSharedPointer<QGraphicsItem> &i) {itemAdded(i.data());});`
	`62`	`+ this, [this](const QSharedPointer<QGraphicsItem> &i) {itemRemoved(i.data());});`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`Box2DPhysicsEngine::~Box2DPhysicsEngine(){`