Skip to content

Commit 3722d92

Browse files
committed
Use common QsLog by default
1 parent acf712e commit 3722d92

File tree

4 files changed

+15
-18
lines changed

4 files changed

+15
-18
lines changed

.github/workflows/common_build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
os: macos-14
7474
build: true
7575
build_installer: true
76-
qmake_extra: "CONFIG+=use_same_qslog CONFIG+=noPch CONFIG+=ccache CONFIG+=no-sanitizers CONFIG+=silent CONFIG+=warn_off"
76+
qmake_extra: "CONFIG+=noPch CONFIG+=ccache CONFIG+=no-sanitizers CONFIG+=silent CONFIG+=warn_off"
7777
trik_python3_version_minor: 11
7878
tests: true
7979
secrets: inherit
@@ -160,7 +160,7 @@ jobs:
160160
build: true
161161
build_installer: true
162162
tests: true
163-
qmake_extra: "CONFIG+=use_same_qslog CONFIG+=noPch CONFIG+=ccache CONFIG+=no-sanitizers CONFIG+=warn_off"
163+
qmake_extra: "CONFIG+=noPch CONFIG+=ccache CONFIG+=no-sanitizers CONFIG+=warn_off"
164164
gcc_version: 13
165165
trik_qt_version: 5.15
166166
trik_python3_version_minor: 11

.github/workflows/windows_build_with_installer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ jobs:
133133
timeout-minutes: 1
134134
run: |
135135
cd ${{ env.BUILD_DIR }}
136-
qmake $GITHUB_WORKSPACE/studio.pro -spec win32-g++ CONFIG+=use_same_qslog CONFIG+=release CONFIG+=sanitizer CONFIG+=sanitize_undefined CONFIG+=tests CONFIG+=noPch PYTHON_PATH="${pythonLocation}" PYTHON_VERSION=${{matrix.python-version}}
136+
qmake $GITHUB_WORKSPACE/studio.pro -spec win32-g++ CONFIG+=release CONFIG+=sanitizer CONFIG+=sanitize_undefined CONFIG+=tests CONFIG+=noPch PYTHON_PATH="${pythonLocation}" PYTHON_VERSION=${{matrix.python-version}}
137137
138138
- name: QMake all
139139
timeout-minutes: 5

plugins/robots/thirdparty/trikRuntime/trikRuntime.pro

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ CONFIG += trik_not_brick
1919
cache(CONFIG, set)
2020

2121
SUBDIRS += \
22-
trikRuntimeQsLog \
2322
trikKernel \
2423
trikNetwork \
2524
trikControl \
@@ -29,6 +28,17 @@ SUBDIRS += \
2928
mlx90640-library \
3029
# translations \
3130

31+
EXTERNAL_SETTINGS = $$PWD/trikRuntimeExternal.pri
32+
cache(EXTERNAL_SETTINGS, set stash super)
33+
34+
trikRuntime_use_local_qslog {
35+
SUBDIRS += trikRuntimeQsLog
36+
trikRuntimeQsLog.file = $$PWD/trikRuntime/qslog/QsLogSharedLibrary.pro
37+
EXTERNAL_SETTINGS =
38+
cache(EXTERNAL_SETTINGS, set stash super)
39+
trikKernel.depends = trikRuntimeQsLog
40+
}
41+
3242
tests {
3343
SUBDIRS *= tests
3444
tests.depends = trikScriptRunner trikCommunicator trikKernel
@@ -50,19 +60,6 @@ trikHal.subdir = $$PWD/trikRuntime/trikHal
5060
mlx90640-library.subdir = $$PWD/trikRuntime/mlx90640-library
5161

5262
trikControl.depends = trikKernel trikHal mlx90640-library
53-
54-
CONFIG(use_same_qslog) {
55-
SUBDIRS -= trikRuntimeQsLog
56-
EXTERNAL_SETTINGS = $$PWD/trikRuntimeExternal.pri
57-
cache(EXTERNAL_SETTINGS, set stash super)
58-
} else {
59-
trikRuntimeQsLog.file = $$PWD/trikRuntime/qslog/QsLogSharedLibrary.pro
60-
EXTERNAL_SETTINGS =
61-
cache(EXTERNAL_SETTINGS, set stash super)
62-
trikKernel.depends = trikRuntimeQsLog
63-
tests.depends += trikRuntimeQsLog
64-
}
65-
6663
trikNetwork.depends = trikKernel
6764
trikScriptRunner.depends += trikControl trikKernel trikNetwork
6865
trikHal.depends = trikKernel

0 commit comments

Comments
 (0)