Clazy support (#1948)

* Add Clazy linter
* Ignore thirdparty dirs
* Run only for modified files
* Treat all warnings as errors (?)

Author: MinyazevR

.github/workflows/common_build.yml

@@ -40,7 +40,7 @@ jobs:
     uses: ./.github/workflows/setup_environment.yml
     with:
       os: ubuntu-latest
-      lint: true
+      lint_vera: true
       build: false
       build_installer: false
 
@@ -93,6 +93,7 @@ jobs:
       build_installer: false
       qmake_extra: "CONFIG+=tests CONFIG+=noPch CONFIG+=ccache CONFIG+=no-sanitizers CONFIG+=use_system_qscintilla2 CONFIG+=use_system_quazip"
       trik_python3_version_minor: 10
+      lint_clazy: true
 
   build-ubuntu-debug-tests:
     needs: lint

.github/workflows/setup_environment.yml

@@ -10,7 +10,11 @@ on:
         required: false
         type: string
         default: "time"
-      lint:
+      lint_vera:
+        required: false
+        type: boolean
+        default: false
+      lint_clazy:
         required: false
         type: boolean
         default: false
@@ -99,7 +103,7 @@ jobs:
       uses: actions/checkout@v4
       with:
         submodules: recursive
-        fetch-depth: 0
+        fetch-depth: 2
 
     - name: Remove thirdparty submodules (use from libs from distro)
       run: |
@@ -124,11 +128,11 @@ jobs:
         INSTALL_INSTALLER_ENVIRONMENT: ${{ inputs.linux_installer_environment }}
       if: ${{ inputs.build }}
 
-    - name: Lint
+    - name: Lint Vera
       run: |
           sudo apt-get update && sudo apt-get install -y --no-install-recommends qttools5-dev-tools qtbase5-dev vera++ 
           ${{ inputs.executor }} buildScripts/github/vera_translation.sh
-      if: ${{ inputs.lint }}
+      if: ${{ inputs.lint_vera }}
 
     - name: Restore cache
       uses: actions/cache@v4
@@ -152,6 +156,7 @@ jobs:
         CONFIG: ${{ inputs.config }}
         EXECUTOR: ${{ inputs.executor }}
         QMAKE_EXTRA: ${{ inputs.qmake_extra }}
+        NEED_COMPILE_DATABASE: ${{ inputs.lint_clazy }}
       if: ${{ inputs.build }}
 
     - name: Save build cache
@@ -168,6 +173,17 @@ jobs:
         TESTS: ${{ inputs.tests }}
       if: ${{ inputs.build == true }}
 
+    - name: Clazy-standalone
+      uses: MinyazevR/clazy-standalone-action@v0.3.2
+      with:
+        checks: 'level0,level1,level2'
+        database: './compile_commands.json'
+        fail-on-warning: true
+        install-stable: true
+        only-diff: true
+        ignore-dirs: '^(buildScripts|thirdparty|installer)$'
+      if: ${{ inputs.lint_clazy }}
+
     - name: Build Installer
       run: |
         buildScripts/github/build_installer.sh

buildScripts/github/build_internal.sh

@@ -15,6 +15,10 @@ rm -f .qmake.cache
 qmake -Wall PYTHON_VERSION=3.$TRIK_PYTHON3_VERSION_MINOR PYTHON_PATH=/usr CONFIG+=$CONFIG $QMAKE_EXTRA $PROJECT.pro
 make -j $(nproc) qmake_all 2>&1 | tee -a build.log
 ccache -s
-make -j $(nproc) all 2>&1 | tee -a build.log
+if [ "$NEED_COMPILE_DATABASE" = "true" ]; then
+  bear -- make -j $(nproc) all 2>&1 | tee -a build.log
+else
+  make -j $(nproc) all 2>&1 | tee -a build.log
+fi
 ccache -s
 ls bin

buildScripts/github/install.sh

@@ -53,7 +53,7 @@ case "$(uname)" in
     elif [ "$ID" = "ubuntu" ]; then
       sudo apt-get update && sudo apt-get install -y --no-install-recommends ccache curl libusb-1.0-0-dev \
       make qtscript5-dev qttools5-dev-tools qtmultimedia5-dev libqt5serialport5-dev libqt5svg5-dev \
-      libudev-dev "$TRIK_PYTHON"-dev qtbase5-private-dev qtwayland5 libqscintilla2-qt5-dev libquazip5-dev
+      libudev-dev "$TRIK_PYTHON"-dev qtbase5-private-dev qtwayland5 libqscintilla2-qt5-dev libquazip5-dev bear
     elif [[ "$ID" = "rocky" || "$ID" = '"rocky"' ]]; then
       GCC_VERSION=${GCC_VERSION:-13}
       sudo yum update -y &&  sudo yum install -y --setopt=install_weak_deps=False epel-release