Fix Vera++ issues

Author: MinyazevR

plugins/robots/common/twoDModel/src/engine/constraints/details/template.cpp

@@ -80,18 +80,22 @@ void XmlTemplate::processParams(const QDomElement &params)
 	auto &&firstParamDecl = params.firstChildElement("param");
 	while (!firstParamDecl.isNull()) {
 		if (firstParamDecl.tagName() != "param") {
-			addDeclarationError(QObject::tr(R"(the <params> tag can only contain the <param> tag as a child tag for template %1,
+			addDeclarationError(QObject::tr(R"(the <params> tag can only contain
+					the <param> tag as a child tag for template %1,
 					actual tag is <%2>)")
-				   .arg(mId, firstParamDecl.tagName()), firstParamDecl.lineNumber(), TemplateParseErrorCode::ParamsTagContainOnlyParam);
+					.arg(mId, firstParamDecl.tagName()), firstParamDecl.lineNumber(),
+					TemplateParseErrorCode::ParamsTagContainOnlyParam);
 			return;
 		}
 
 		auto &&paramName = firstParamDecl.attribute("name");
 
 		if (paramName.isEmpty()) {
 			addDeclarationError(QObject::tr(
-				R"(The <param> tag of template %1 was provided, but the required "name" attribute was missing.)")
-				   .arg(mId), firstParamDecl.lineNumber(), TemplateParseErrorCode::MissingParamNameAttribute);
+				R"(The <param> tag of template %1 was provided,
+				 but the required "name" attribute was missing.)")
+				 .arg(mId), firstParamDecl.lineNumber(),
+				 TemplateParseErrorCode::MissingParamNameAttribute);
 			return;
 		}
 
@@ -144,8 +148,9 @@ void XmlTemplate::processDeclaration(const QDomElement &templateDeclaration)
 	auto &&contentDecl = templateDeclaration.firstChildElement("content");
 	if (contentDecl.isNull()) {
 		addDeclarationError(QObject::tr(
-			R"(The <template> of template %1 tag was provided, but the required child tag <content> was missing.)")
-			   .arg(mId), templateDeclaration.lineNumber(), TemplateParseErrorCode::MissingContentTag);
+			R"(The <template> of template %1 tag was provided,
+			but the required child tag <content> was missing.)")
+			.arg(mId), templateDeclaration.lineNumber(), TemplateParseErrorCode::MissingContentTag);
 		return;
 	}
 	processContent(contentDecl);
@@ -163,7 +168,8 @@ bool XmlTemplate::validateParam(const QDomNode &with, const QString &param)
 	return true;
 }
 
-void XmlTemplate::parseParams(const QDomElement &paramTag, QHash<QString, QString> &paramsForReplace, bool fromTemplate)
+void XmlTemplate::parseParams(const QDomElement &paramTag,
+			      QHash<QString, QString> &paramsForReplace, bool fromTemplate)
 {
 	auto &&attributes = paramTag.attributes();
 	for (int i = 0; i < attributes.length(); i++) {
@@ -221,8 +227,10 @@ QString XmlTemplate::substitute(const QDomElement &templateUsage)
 		if (value == paramsForReplace.end()) {
 			if (!declaredParam.mHasDefaultValue) {
 				addSubstitutionError(
-				QObject::tr("The parameter %1 of template %2 has no default value and was not explicitly specified by the user")
-						.arg(*it, mId), templateUsage.lineNumber(), TemplateSubstitutionErrorCode::MissingReqiuredParam);
+				QObject::tr("The parameter %1 of template %2 has no default"
+					    " value and was not explicitly specified by the user")
+					    .arg(*it, mId), templateUsage.lineNumber(),
+					    TemplateSubstitutionErrorCode::MissingReqiuredParam);
 				continue;
 			}
 			substitute(*it, declaredParam.mDefaultValue, result);

plugins/robots/common/twoDModel/src/engine/constraints/details/template.h

@@ -26,7 +26,8 @@ namespace details {
 
 /*!
  * \class XmlTemplate
- * \brief A class that describes a template and stores information about its parameters, default substitution value, substitution order, and more
+ * \brief A class that describes a template and stores information about its parameters, default substitution value,
+ * substitution order, and more
  * \inmodule twoDModel::constraints::details
  *
  * General view of template declaration:
@@ -60,7 +61,8 @@ namespace details {
  * The order in which parameters are defined in a template determines the order in which they are initialized.
  * In the example above, the nestedVariable parameter can be used in the default value for the xml_node parameter.
  */
-class XmlTemplate {
+class XmlTemplate
+{
 public:
 	XmlTemplate(const XmlTemplate&) = delete;
 	XmlTemplate& operator=(const XmlTemplate&) = delete;
@@ -131,7 +133,8 @@ class XmlTemplate {
 	void parseWith(const QDomElement &with, QHash<QString, QString> &paramsForReplace);
 
 	bool validateParam(const QDomNode &with, const QString &param);
-	void parseParams(const QDomElement &paramTag, QHash<QString, QString> &paramsForReplace, bool fromTemplate = false);
+	void parseParams(const QDomElement &paramTag, QHash<QString, QString>
+			 &paramsForReplace, bool fromTemplate = false);
 	void substitute(const QString& name, const QString& value, QString &result);
 	void clear();
 

plugins/robots/common/twoDModel/src/engine/constraints/details/templatesParser.cpp

@@ -151,16 +151,19 @@ QDomElement TemplatesParser::processTemplate(const QDomElement &elements, Expans
 
 	if (context.mMacrosInProgress.contains(templateName)) {
 		substituteError(QObject::tr(
-		    "Recursive template expansion detected: %1 -> %2")
-		    .arg(context.mOrder.join(" -> "), templateName), elements. lineNumber(), context, SubstitutionErrorCode::RecursiveTemplateExpansion);
+			"Recursive template expansion detected: %1 -> %2")
+			.arg(context.mOrder.join(" -> "), templateName), elements.lineNumber(),
+			context, SubstitutionErrorCode::RecursiveTemplateExpansion);
 		return {};
 	}
 
 	auto *foundTemplate = findTemplate(templateName);
 
 	if (!foundTemplate) {
-		substituteError(QObject::tr(R"(The <use> tag contains a template=%1 attribute that is not the name of a declared template)")
-				.arg(templateName), elements.lineNumber(), context, SubstitutionErrorCode::UseUndeclaredTemplate);
+		substituteError(QObject::tr(R"(The <use> tag contains a template=%1 attribute
+				that is not the name of a declared template)")
+				.arg(templateName), elements.lineNumber(), context,
+				SubstitutionErrorCode::UseUndeclaredTemplate);
 		return {};
 	}
 
@@ -182,7 +185,8 @@ QDomElement TemplatesParser::processTemplate(const QDomElement &elements, Expans
 		QObject::tr("After substituting the parameters for"
 			    " the template %1, it did not become a valid xml node").arg(templateName);
 	if (!result.setContent(wrappedXml, &errorMessage, &errorLine)) {
-		substituteError(QString("%1 %2").arg(message, errorMessage), errorLine, context, SubstitutionErrorCode::QtXmlParserError);
+		substituteError(QString("%1 %2").arg(message, errorMessage), errorLine, context,
+				SubstitutionErrorCode::QtXmlParserError);
 		return {};
 	}
 
@@ -285,7 +289,8 @@ void TemplatesParser::parseError(const QString& message, int line, ParserErrorCo
 	mParsingErrors << message + " " + QObject::tr("line %1").arg(line);
 }
 
-void TemplatesParser::substituteError(const QString& message, int line, const ExpansionContext &context, SubstitutionErrorCode code)
+void TemplatesParser::substituteError(const QString& message, int line,
+				      const ExpansionContext &context, SubstitutionErrorCode code)
 {
 	Q_UNUSED(code)
 	QLOG_ERROR() << message + " " + QObject::tr("line %1").arg(line)

plugins/robots/common/twoDModel/src/engine/constraints/details/templatesParser.h

@@ -89,7 +89,8 @@ class TemplatesParser
 			return newCtx;
 		}
 	};
-	virtual void substituteError(const QString& message, int line, const ExpansionContext &context, SubstitutionErrorCode code);
+	virtual void substituteError(const QString& message, int line,
+				     const ExpansionContext &context, SubstitutionErrorCode code);
 private:
 	/// It is used to parse all templates from the directory. Thus, each xml file in the directory will be examined,
 	/// and each file will search for the top-level template or templates tag.

plugins/robots/common/twoDModel/src/engine/model/model.cpp

@@ -194,7 +194,8 @@ void Model::deserialize(const QDomDocument &model)
 				mChecker->parseConstraints(constraints, importedNode);
 			}
 		}
-		// If something goes wrong with the template system at some point, the user can simply not use Constraint Parser directly.
+		// If something goes wrong with the template system at some point, the user can
+		// simply not use Constraint Parser directly.
 		else if(templates.isNull()) {
 			const auto &constraints = model.documentElement().firstChildElement("constraints");
 			mChecker->parseConstraints(constraints, constraints);