Improve binarycreator logging and fail if artifact is missing (#1898)

* Verbose binarycreator for debug purposes

* Fail if no installer found for test

Author: iakov

buildScripts/github/build_installer.sh

@@ -3,10 +3,10 @@ set -euxo pipefail
 BRANCH_NAME="${BRANCH_NAME:-${GITHUB_REF#refs/*/}}"
 BRANCH_NAME=${BRANCH_NAME//\//-}
 
-QTBIN=${QTBIN:-$($EXECUTOR  bash -c 'eval $(make qmake -n | cut -f 1 -d " ") -query QT_INSTALL_BINS')}
-case $RUNNER_OS in
+QTBIN="${QTBIN:-$($EXECUTOR  bash -c 'eval $(make qmake -n | cut -f 1 -d " ") -query QT_INSTALL_BINS')}"
+case "$RUNNER_OS" in
   macOS)
-    QTIFWBIN=$HOME/qtifw/bin
+    QTIFWBIN="$HOME"/qtifw/bin
     TSNAME="trik-studio-installer-mac-$BRANCH_NAME.dmg"
     ;;
   Linux)
@@ -19,23 +19,23 @@ df -h .
 
 NEED_DEPLOY=$([[ "$GITHUB_REPOSITORY" == "trikset/trik-studio" && "${PULLREQUESTNUMBER:-false}" == "false" ]] && echo true || echo false )
 
-if $NEED_DEPLOY ; then
+if "$NEED_DEPLOY" ; then
     $EXECUTOR bash -c "mkdir -p $HOME/.ssh && install -m 600 /dev/null $HOME/.ssh/id_rsa && echo \"$ssh_key\" > $HOME/.ssh/id_rsa"
 fi
 
-if [[ $RUNNER_OS == Linux ]] ; then
+if [[ "$RUNNER_OS" == Linux ]] ; then
       echo Start build checker archive
       $EXECUTOR bash -c "bin/build-checker-installer.sh"
-      if $NEED_DEPLOY ; then
+      if "$NEED_DEPLOY" ; then
           $EXECUTOR bash -c "rsync -v --rsh='ssh -o StrictHostKeyChecking=no -vvv -i $HOME/.ssh/id_rsa' bin/trik_checker.tar.xz $username@$host:~/dl/ts/fresh/checker/checker-linux-$CONFIG-$BRANCH_NAME.tar.xz"
       fi
 fi
 
 echo Start build installer
 $EXECUTOR bash -c "installer/build-trik-studio.sh $QTBIN $QTIFWBIN ."
 
-INSTALLER_NAME=$(find installer -name "trik-studio*installer*" -print -quit)
+INSTALLER_NAME=$(find installer -name "trik-studio*installer*" -print -quit | grep . ) 
 
-if $NEED_DEPLOY ; then
+if "$NEED_DEPLOY" ; then
     $EXECUTOR bash -c "rsync -v --rsh='ssh -o StrictHostKeyChecking=no -vvv -i $HOME/.ssh/id_rsa' $INSTALLER_NAME $username@$host:~/dl/ts/fresh/installer/$TSNAME"
 fi

installer/build-installer.sh

@@ -81,19 +81,19 @@ find $PWD/packages/$PRODUCT -name prebuild-$OS.sh | bash -xe
 find . -type d -empty -delete
 
 #echo "Building online installer..."
-#$QTIFW_DIR/binarycreator --online-only -c config/$PRODUCT-$OS_EXT.xml -p packages/qreal-base -p packages/$PRODUCT ${*:4} $PRODUCT-online-$OS_EXT-installer
+#$QTIFW_DIR/binarycreator --verbose --online-only -c config/$PRODUCT-$OS_EXT.xml -p packages/qreal-base -p packages/$PRODUCT ${*:4} $PRODUCT-online-$OS_EXT-installer
 
 echo "Building offline installer..."
 case $(uname -s || echo None) in
   Linux) INSTALLER_EXT=.run;;
   Darwin) INSTALLER_EXT=.dmg;;
   *) INSTALLER_EXT=.exe;;
 esac
-$QTIFW_DIR/binarycreator --offline-only -c config/$PRODUCT-$OS_EXT.xml -p packages/qreal-base -p packages/$PRODUCT $PRODUCT-offline-$OS_EXT-installer$ADD_BIT-${FULL_VERSION}${INSTALLER_EXT}
+"$QTIFW_DIR"/binarycreator --verbose --offline-only -c "config/$PRODUCT-$OS_EXT.xml" -p packages/qreal-base -p "packages/$PRODUCT" "$PRODUCT-offline-$OS_EXT-installer$ADD_BIT-${FULL_VERSION}${INSTALLER_EXT}"
 
 grep -r -l --include=*.xml '<Version>.*</Version>' . | xargs $GNU_SED_COMMAND -i -e "s/<Version>.*<\/Version>/<Version><\/Version>/"
 
-[ -f $SSH_DIR/id_rsa ] && : || { echo "Done"; exit 0; }
+[ -f "$SSH_DIR/id_rsa" ] && : || { echo "Done"; exit 0; }
 
 #echo "Building updates repository... This step can be safely skipped, the offline installer is already ready, press Ctrl+C if you are not sure what to do next."
 #rm -rf $PRODUCT-repository
@@ -103,6 +103,6 @@ grep -r -l --include=*.xml '<Version>.*</Version>' . | xargs $GNU_SED_COMMAND -i
 #scp -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -r $PRODUCT-repository/* qrealproject@195.19.241.150:/home/qrealproject/public/packages/$PRODUCT-repo-$OS_EXT
 
 echo "Removing temporary files..."
-rm -rf $PRODUCT-repository
+rm -rf "$PRODUCT-repository"
 
 echo "Done"