Skip to content

Commit c05b71a

Browse files
authored
Merge pull request #818 from iakov/fix/crash_ev3_options
Use of zorder option causes crash
2 parents bc4a5b9 + 9a474b1 commit c05b71a

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

plugins/robots/interpreters/ev3KitInterpreter/src/ev3AdditionalPreferences.ui

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
</property>
2929
<item row="0" column="0">
3030
<widget class="qReal::ui::ImagePicker" name="robotImagePicker" native="true">
31-
<zorder>bluetoothSettingsGroupBox</zorder>
3231
</widget>
3332
</item>
3433
<item row="1" column="0">

qrgraph/src/queries.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ QList<const Node *> Queries::immediateFollowers(const Node &node, uint edgeType)
127127
}
128128
}
129129

130-
return result.toList();
130+
return result.values();
131131
}
132132

133133
QList<const Node *> Queries::immediatePredecessors(const Node &node, uint edgeType)
@@ -140,12 +140,12 @@ QList<const Node *> Queries::immediatePredecessors(const Node &node, uint edgeTy
140140
}
141141
}
142142

143-
return result.toList();
143+
return result.values();
144144
}
145145

146146
QList<const Node *> Queries::reachableSet(const Node &node, uint edgeType)
147147
{
148148
QSet<const Node *> result;
149149
::dfs(node, [](const Node &) {return false;}, edgeType, result);
150-
return result.toList();
150+
return result.values();
151151
}

qrtext/src/core/types/typeVariable.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ TypeVariable::TypeVariable(const QSharedPointer<TypeExpression> &singleType)
3232

3333
bool TypeVariable::isResolved() const
3434
{
35-
return mAllowedTypes.size() == 1 && !mAllowedTypes.toList().first()->is<Any>();
35+
return mAllowedTypes.size() == 1 && !mAllowedTypes.values().first()->is<Any>();
3636
}
3737

3838
bool TypeVariable::isEmpty() const
@@ -42,17 +42,17 @@ bool TypeVariable::isEmpty() const
4242

4343
QSharedPointer<TypeExpression> TypeVariable::finalType() const
4444
{
45-
if (mAllowedTypes.size() == 0) {
45+
if (mAllowedTypes.empty()) {
4646
return QSharedPointer<TypeExpression>(new Any());
4747
} else {
48-
return mAllowedTypes.toList()[0].dynamicCast<TypeExpression>();
48+
return mAllowedTypes.begin()->dynamicCast<TypeExpression>();
4949
}
5050
}
5151

5252
void TypeVariable::constrain(const QSharedPointer<TypeVariable> &other
5353
, const GeneralizationsTableInterface &generalizationsTable)
5454
{
55-
constrain(other->mAllowedTypes.toList(), generalizationsTable);
55+
constrain(other->mAllowedTypes.values(), generalizationsTable);
5656
}
5757

5858
void TypeVariable::constrain(const QList<QSharedPointer<TypeExpression>> &types

qrtranslations/fr/plugins/robots/ev3KitInterpreter_fr.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<translation type="vanished">Wi-Fi</translation>
2626
</message>
2727
<message>
28-
<location line="+23"/>
28+
<location line="+22"/>
2929
<source>Robot&apos;s Folders</source>
3030
<translation type="unfinished"></translation>
3131
</message>

qrtranslations/ru/plugins/robots/ev3KitInterpreter_ru.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
<message>
77
<location filename="../../../../plugins/robots/interpreters/ev3KitInterpreter/src/ev3AdditionalPreferences.ui" line="+14"/>
88
<source>Form</source>
9-
<translation>Настроки EV3</translation>
9+
<translation>Настройки EV3</translation>
1010
</message>
1111
<message>
12-
<location line="+23"/>
12+
<location line="+22"/>
1313
<source>Robot&apos;s Folders</source>
1414
<translation>Папки Робота</translation>
1515
</message>

0 commit comments

Comments
 (0)