Skip to content

Commit de47394

Browse files
committed
GHI CI: stop on install_qt fail
1 parent 1942bea commit de47394

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

buildScripts/github/install.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ case "$(uname)" in
3636
sudo port selfupdate
3737
sudo port install libusb +universal
3838

39-
install_qt mac desktop "${TRIK_QT_VERSION}" "$HOME/Qt" $qt_modules $qt_archives
39+
install_qt mac desktop "${TRIK_QT_VERSION}" "$HOME/Qt" qt_modules qt_archives
4040
sudo xcode-select -s /Applications/Xcode_${XCODE_VERSION}.app/Contents/Developer
4141
xcodebuild -showsdks
4242
xcrun -sdk macosx --show-sdk-path
@@ -72,7 +72,7 @@ case "$(uname)" in
7272
#libQt5WaylandCompositor.so.5.15: libQt5Quick.so.5 libQt5Qml.so.5 libQt5QmlModels.so.5
7373
qt_modules+=("qtwaylandcompositor")
7474
qt_archives+=("icu" "qtwayland")
75-
install_qt linux desktop "$TRIK_QT_VERSION" "$HOME/Qt" $qt_modules $qt_archives
75+
install_qt linux desktop "$TRIK_QT_VERSION" "$HOME/Qt" qt_modules qt_archives
7676
QT_ROOT_DIR=$(ls -1d "$HOME"/Qt/$TRIK_QT_VERSION*/gcc_64 | head -n 1)
7777
echo "$QT_ROOT_DIR/bin" >> $GITHUB_PATH
7878
fi

buildScripts/github/install_linter.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ sudo apt-get update && sudo apt-get install -y --no-install-recommends vera++
88

99
modules=("qtscript" "qtwaylandcompositor")
1010
archives=("qtbase" "qtmultimedia" "qtsvg" "qtscript" "qttools" "qtserialport" "qtimageformats" "icu" "qtwayland" "qtdeclarative" "qttranslations" "qtsvgwidgets" "qtxmlpatterns" "qtwebenginewidgets" "qtwebkit" "qtwebkitwidgets")
11-
install_qt linux desktop "$TRIK_QT_VERSION" "$HOME/Qt" $modules $archives
11+
install_qt linux desktop "$TRIK_QT_VERSION" "$HOME/Qt" modules archives
1212
QT_ROOT_DIR=$(ls -1d "$HOME"/Qt/$TRIK_QT_VERSION*/gcc_64 | head -n 1)
1313
echo "$QT_ROOT_DIR/bin" >> $GITHUB_PATH
1414
export PATH="$QT_ROOT_DIR/bin:$PATH"

buildScripts/github/utilities.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ get_array_by_name() {
2424
}
2525

2626

27-
install_qt(){
27+
install_qt() {
2828
# Usage: install_qt <os> <platform-type> <qt-version> <path-to-install-qt> <modules> <archives>
2929
# TODO: add <addittional-options>
3030
"$TRIK_PYTHON" -m venv venv
@@ -35,8 +35,8 @@ install_qt(){
3535

3636

3737
local -a get_array_by_name_result=() #declare before call
38-
[[ -n "$5:-" ]] && get_array_by_name "${5}" && (( ${#get_array_by_name_result[@]} > 0 )) && cmd+=("-m" "${get_array_by_name_result[@]}")
39-
[[ -n "$6:-" ]] && get_array_by_name "${6}" && (( ${#get_array_by_name_result[@]} > 0 )) && cmd+=("--archives" "${get_array_by_name_result[@]}")
38+
if [[ -n "$5:-" ]] ; then { get_array_by_name "${5}" || return 1 ; (( ${#get_array_by_name_result[@]} > 0 )) && cmd+=("-m" "${get_array_by_name_result[@]}") ; } ; fi
39+
if [[ -n "$6:-" ]] ; then { get_array_by_name "${6}" || return 1 ; (( ${#get_array_by_name_result[@]} > 0 )) && cmd+=("--archives" "${get_array_by_name_result[@]}") ; } ; fi
4040

4141
"${cmd[@]}"
4242

0 commit comments

Comments
 (0)