We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 0534875 commit 82c48f0Copy full SHA for 82c48f0
trikScriptRunner/src/scriptEngineWorker.cpp
@@ -128,6 +128,10 @@ void ScriptEngineWorker::stopScript()
128
129
if (mMailbox) {
130
mMailbox->stopWaiting();
131
+ /// @todo: here script will continue to execute and may execute some statements before it will eventually
132
+ /// be stopped by mThreading.reset(). But if we do mThreading.reset() before mMailbox->stopWaiting(),
133
+ /// we will get deadlock, since mMailbox->stopWaiting() shall be executed in already stopped thread.
134
+ /// Actually we shall stop script engines here, do mMailbox->stopWaiting(), then stop threads.
135
}
136
137
mThreading.reset();
0 commit comments