Zoltan: Cannot compile with metis enabled and parmetis disabled

[rezahousseini]

Bug Report

I am packaging Zoltan for Guix. You find my pull request here.
But I have disabled metis in it. You can reproduce the error by setting TPL_ENABLE_METIS to ON.

Description

When compiling Zoltan with -DTPL_ENABLE_METIS=ON compilation fails with error Zoltan_ParMetis undefined, although it is defined in the file packages/zoltan/src/tpls/parmetis_interface.h but which seems no to be included anywhere.

Steps to Reproduce

1. version 16.1.0
2. Pass flag -DTPL_ENABLE_METIS=ON to cmake
3. Observe error Zoltan_ParMetis undefined

[cgcgcg]

@egboman

[egboman]

In Trilinos (and Zoltan), Metis and ParMetis are two separate libraries. Please use -DTPL_ENABLE_PARMETIS=ON to enable ParMetis. That said, it should be possible to use Metis without ParMetis installed. Is this the issue?

[rezahousseini]

I think this is the issue, when I enable metis with -DTPL_ENABLE_METIS=ON I get an error about undefined Zoltan_ParMetis

[cgcgcg]

@rezahousseini I have some trouble understanding the issue. Is this what you do?

• You set TPL_ENABLE_METIS=ON and TPL_ENABLE_ParMETIS=OFF.
• During compilation of Zoltan, you get an undefined reference to Zoltan_ParMetis.

If so, would you mind posting the error message, just in case it contains additional information?

[rezahousseini]

The error message is

/tmp/guix-build-trilinos-zoltan-16.1.0.drv-0/Trilinos-tags-trilinos-release-16-1-0/packages/zoltan/src/tpls/third_library.c: In function ‘Zoltan_Graph’:
/tmp/guix-build-trilinos-zoltan-16.1.0.drv-0/Trilinos-tags-trilinos-release-16-1-0/packages/zoltan/src/tpls/third_library.c:74:10: error: implicit declaration of function ‘Zoltan_ParMetis’; did you mean ‘Zoltan_ParMetis_Order’? [-Wimplicit-function-declaration]
   74 |     rc = Zoltan_ParMetis(zz, part_sizes, num_imp, imp_gids, imp_lids,
      |          ^~~~~~~~~~~~~~~
      |          Zoltan_ParMetis_Order

my configuration flags are

"-DTrilinos_ENABLE_Zoltan=ON"
"-DBUILD_SHARED_LIBS=ON"
"-DTPL_ENABLE_MPI=ON"
"-DTPL_ENABLE_METIS=ON"
 "-DTPL_ENABLE_ParMETIS=OFF"
  "-DTPL_ENABLE_Scotch=ON"
  "-DTPL_ENABLE_Zlib=ON"
  "-DTrilinos_ENABLE_Fortran=OFF"
  "-DZoltan_ENABLE_TESTS=ON"

Hope this clarifies the issue.

[cgcgcg]

@rezahousseini Can you try to build without -Wimplicit-function-declaration?

[egboman]

Works for me, but there were a few warnings.

[rezahousseini]

hmm doesn't seem to work here, am I missing something? I added the flag "-DCMAKE_C_FLAGS=-Wno-implicit-function-declaration" and get the error and similar

/tmp/guix-build-trilinos-zoltan-16.1.0.drv-0/Trilinos-tags-trilinos-release-16-1-0/packages/zoltan/src/tpls/scotch_interface.c: In function ‘Zoltan_Scotch_Order’:
/tmp/guix-build-trilinos-zoltan-16.1.0.drv-0/Trilinos-tags-trilinos-release-16-1-0/packages/zoltan/src/tpls/scotch_interface.c:292:54: error: passing argument 3 of ‘SCOTCH_graphOrder’ from incompatible pointer type [-Wincompatible-pointer-types]
  292 |     ierr = SCOTCH_graphOrder(&cgrafdat, &stradat, ord.rank, ord.iperm,
      |                                                   ~~~^~~~~
      |                                                      |
      |                                                      idx_t * {aka int *}
In file included from /gnu/store/l7zw1caj3i4h0sjk9z8ix9slphig9dqp-pt-scotch-7.0.7/include/ptscotch.h:73,
                 from /tmp/guix-build-trilinos-zoltan-16.1.0.drv-0/Trilinos-tags-trilinos-release-16-1-0/packages/zoltan/src/tpls/third_library_const.h:41,
                 from /tmp/guix-build-trilinos-zoltan-16.1.0.drv-0/Trilinos-tags-trilinos-release-16-1-0/packages/zoltan/src/zz/zz_const.h:26,
                 from /tmp/guix-build-trilinos-zoltan-16.1.0.drv-0/Trilinos-tags-trilinos-release-16-1-0/packages/zoltan/src/tpls/scotch_interface.c:18:
/gnu/store/l7zw1caj3i4h0sjk9z8ix9slphig9dqp-pt-scotch-7.0.7/include/scotch.h:307:94: note: expected ‘SCOTCH_Num * const’ {aka ‘long int * const’} but argument is of type ‘idx_t *’ {aka ‘int *’}
  307 | int                         SCOTCH_graphOrder   (SCOTCH_Graph * const, SCOTCH_Strat * const, SCOTCH_Num * const, SCOTCH_Num * const, SCOTCH_Num * const, SCOTCH_Num * const, SCOTCH_Num * const);
      |                                                                                              ^~~~~~~~~~~~~~~~~~

[cgcgcg]

Somewhere you enabled all warnings to be treated as errors. Disabling one particular flag got you past the previous error. Now you are seeing the next one.

[egboman]

@rezahousseini Any update? Are you still having problems?