Merge pull request #458 from trimble-oss/452-memory-leakage-on-modus-controls

Dropdown popup is not opening in .net 10 #457

Author: amosekr

Trimble.Modus.Components/Controls/DropDown/DropDownContents.xaml.cs

@@ -39,17 +39,18 @@ internal DropDownContents(View anchorView, Enums.ModalPosition position) : base(
     public Thickness Margin { get; set; }
     public IEnumerable ItemSource { get; set; }
     public double DesiredHeight { get; set; }
+    public double DesiredWidth { get; set; }
     public EventHandler<SelectedItemChangedEventArgs> SelectedEventHandler { get; set; }
     public int SelectedIndex { get; set; }
     public double YPosition { get; set; }
     public new double Height { get; set; }
-
+    public Action ChangeIndicatorWhenPopupRemove { get; set; }
     public void Build()
     {
         Animation = new RevealAnimation(DesiredHeight);
         border.Margin = Margin;
         border.HeightRequest = DesiredHeight;
-        border.WidthRequest = WidthRequest;
+        border.WidthRequest = DesiredWidth;
         listView.ItemsSource = ItemSource;
         if (SelectedIndex < 0)
         {
@@ -70,7 +71,11 @@ public void Build()
 #endif
         }
     }
-
+    protected override void OnDisappearing()
+    {
+        base.OnDisappearing();
+        ChangeIndicatorWhenPopupRemove?.Invoke();
+    }
     private static void UpdateBackgroundColorOfCell(ListView listView)
     {
         if (listView.SelectedItem != null)

Trimble.Modus.Components/Controls/DropDown/TMDropDown.xaml.cs

@@ -244,10 +244,11 @@ private async void Open()
                 SelectedItem = this.SelectedItem,
                 Margin = margin,
                 DesiredHeight = desiredHeight,
-                WidthRequest = innerBorder.Width,
+                DesiredWidth = innerBorder.Width,
                 SelectedEventHandler = OnSelected,
                 YPosition = loc.Y,
-                Height = height
+                Height = height,
+                ChangeIndicatorWhenPopupRemove = OnPopupRemoved
             };
             dropDownContents.Build();
             await Task.WhenAll(
@@ -260,7 +261,7 @@ await Task.WhenAll(
         }
     }
 
-    private void OnPopupRemoved(object sender, EventArgs e)
+    private void OnPopupRemoved()
     {
         Close();
     }
@@ -383,7 +384,12 @@ public void Dispose()
         SelectionChanged = null;
         SelectionChangedCommand = null;
         ItemsSource = null;
-        dropDownContents = null;
+        if (dropDownContents != null)
+        {
+            dropDownContents.ChangeIndicatorWhenPopupRemove = null;
+            dropDownContents = null;
+        }
         previousSelection = null;
+        
     }
 }

Trimble.Modus.Components/Controls/Popup/Animations/RevealAnimation.cs

@@ -19,7 +19,7 @@ public override void Preparing(View content, PopupPage page)
         if (HasBackgroundAnimation)
         {
             _defaultOpacity = page.Opacity;
-            page.HeightRequest = 0;
+            //page.HeightRequest = 0;
         }
         else if (content != null)
         {

Trimble.Modus.Components/Trimble.Modus.Components.csproj

@@ -27,7 +27,7 @@
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <PackageId>Trimble.Modus.Components</PackageId>
     <Title>Trimble Modus</Title>
-    <Version>1.4.0.2</Version>
+    <Version>1.4.0.3</Version>
     <Authors>Trimble Inc</Authors>
     <Company>Trimble Inc</Company>
     <Product>Trimble.Modus.Components</Product>