Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Commit 9df6a4d

Browse files
committed
feat(list): Add component selector option to mdc-list-item-text
Allow's developers to use as both component or directive
1 parent 6545321 commit 9df6a4d

File tree

2 files changed

+61
-13
lines changed

2 files changed

+61
-13
lines changed

src/demo-app/components/list-demo/list-demo.component.html

Lines changed: 60 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,14 @@ <h3>Single-Line</h3>
150150
<mdc-list-item>Single-line item</mdc-list-item>
151151
<mdc-list-item>Single-line item</mdc-list-item>
152152
</mdc-list>
153-
</div>
153+
<pre style="background:#000;color:#f8f8f8"><span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list</span>
154+
[<span style="color:#89bdff">dense</span>]=<span style="color:#65b042">"isSinglelineDense"</span>
155+
[<span style="color:#89bdff">mdc-theme-dark</span>]=<span style="color:#65b042">"false"</span>></span>
156+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>Single-line item<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
157+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>Single-line item<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
158+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>Single-line item<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
159+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list</span>></span>
160+
</pre> </div>
154161
<div fxLayout="column" class="mdc-padding">
155162
<h3>Two-line List</h3>
156163
<div fxLayout="row">
@@ -165,25 +172,49 @@ <h3>Two-line List</h3>
165172
</div>
166173
<mdc-list class="demo-wrapper" [twoLine]="true" [dense]="isTwolineDense" [mdc-theme-dark]="isTwoDarkTheme">
167174
<mdc-list-item>
168-
<span mdc-list-item-text>
175+
<mdc-list-item-text>
169176
Single-line item
170-
<span mdc-list-item-secondary>Secondary text</span>
171-
</span>
177+
<mdc-list-item-secondary>Secondary text</mdc-list-item-secondary>
178+
</mdc-list-item-text>
172179
</mdc-list-item>
173180
<mdc-list-item>
174-
<span mdc-list-item-text>
181+
<mdc-list-item-text>
175182
Single-line item
176-
<span mdc-list-item-secondary>Secondary text</span>
177-
</span>
183+
<mdc-list-item-secondary>Secondary text</mdc-list-item-secondary>
184+
</mdc-list-item-text>
178185
</mdc-list-item>
179186
<mdc-list-item>
180-
<span mdc-list-item-text>
187+
<mdc-list-item-text>
181188
Single-line item
182-
<span mdc-list-item-secondary>Secondary text</span>
183-
</span>
189+
<mdc-list-item-secondary>Secondary text</mdc-list-item-secondary>
190+
</mdc-list-item-text>
184191
</mdc-list-item>
185192
</mdc-list>
186-
</div>
193+
194+
<pre style="background:#000;color:#f8f8f8"><span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list</span>
195+
[<span style="color:#89bdff">twoLine</span>]=<span style="color:#65b042">"true"</span>
196+
[<span style="color:#89bdff">dense</span>]=<span style="color:#65b042">"false"</span>
197+
[<span style="color:#89bdff">mdc-theme-dark</span>]=<span style="color:#65b042">"false"</span>></span>
198+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
199+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-text</span>></span>
200+
Single-line item
201+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-secondary</span>></span>Secondary text<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-secondary</span>></span>
202+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-text</span>></span>
203+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
204+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
205+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-text</span>></span>
206+
Single-line item
207+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-secondary</span>></span>Secondary text<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-secondary</span>></span>
208+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-text</span>></span>
209+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
210+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
211+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-text</span>></span>
212+
Single-line item
213+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-secondary</span>></span>Secondary text<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-secondary</span>></span>
214+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item-text</span>></span>
215+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
216+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list</span>></span>
217+
</pre></div>
187218

188219
<div fxLayout="column" class="mdc-padding">
189220
<h3>Start Detail</h3>
@@ -238,7 +269,24 @@ <h3>Start + End Detail</h3>
238269
<i mdc-list-item-start material-icon>data_usage</i>Data Usage<i mdc-list-item-end material-icon>info</i>
239270
</mdc-list-item>
240271
</mdc-list>
241-
</div>
272+
<pre style="background:#000;color:#f8f8f8"><span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list</span> [<span style="color:#89bdff">mdc-theme-dark</span>]=<span style="color:#65b042">"false"</span>></span>
273+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
274+
<span style="color:#e0c589">&lt;<span style="color:#e0c589">i</span> <span style="color:#e0c589">mdc-list-item-start</span> <span style="color:#e0c589">material-icon</span>></span>network_wifi<span style="color:#e0c589">&lt;/<span style="color:#e0c589">i</span>></span>
275+
Wi-Fi
276+
<span style="color:#e0c589">&lt;<span style="color:#e0c589">i</span> <span style="color:#e0c589">mdc-list-item-end</span> <span style="color:#e0c589">material-icon</span>></span>info<span style="color:#e0c589">&lt;/<span style="color:#e0c589">i</span>></span>
277+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
278+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
279+
<span style="color:#e0c589">&lt;<span style="color:#e0c589">i</span> <span style="color:#e0c589">mdc-list-item-start</span> <span style="color:#e0c589">material-icon</span>></span>bluetooth<span style="color:#e0c589">&lt;/<span style="color:#e0c589">i</span>></span>
280+
Bluetooth
281+
<span style="color:#e0c589">&lt;<span style="color:#e0c589">i</span> <span style="color:#e0c589">mdc-list-item-end</span> <span style="color:#e0c589">material-icon</span>></span>info<span style="color:#e0c589">&lt;/<span style="color:#e0c589">i</span>></span>
282+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
283+
<span style="color:#89bdff">&lt;<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
284+
<span style="color:#e0c589">&lt;<span style="color:#e0c589">i</span> <span style="color:#e0c589">mdc-list-item-start</span> <span style="color:#e0c589">material-icon</span>></span>data_usage<span style="color:#e0c589">&lt;/<span style="color:#e0c589">i</span>></span>
285+
Data Usage
286+
<span style="color:#e0c589">&lt;<span style="color:#e0c589">i</span> <span style="color:#e0c589">mdc-list-item-end</span> <span style="color:#e0c589">material-icon</span>></span>info<span style="color:#e0c589">&lt;/<span style="color:#e0c589">i</span>></span>
287+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list-item</span>></span>
288+
<span style="color:#89bdff">&lt;/<span style="color:#89bdff">mdc</span><span style="color:#89bdff">-list</span>></span>
289+
</pre> </div>
242290

243291
<div fxLayout="column" class="mdc-padding">
244292
<h3>Avatar List</h3>

src/lib/list/list-item.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export class ListItemEndDirective {
6666
}
6767

6868
@Directive({
69-
selector: '[mdc-list-item-text]'
69+
selector: '[mdc-list-item-text], mdc-list-item-text'
7070
})
7171
export class ListItemTextDirective {
7272
@HostBinding('class.mdc-list-item__text') isHostClass = true;

0 commit comments

Comments
 (0)