fix(text-field): Should compare using coerced value (#1231)

trimox · web-flow · commit f40759f9d9a0 · 2018-08-16T20:40:12.000-04:00
diff --git a/packages/textfield/text-field.ts b/packages/textfield/text-field.ts
@@ -435,7 +435,7 @@ export class MdcTextField implements AfterContentInit, OnDestroy, ControlValueAc
   setBox(box: boolean): void {
     this._box = toBoolean(box);
 
-    if (this.outline && box) {
+    if (this.outline && this.box) {
       this.outline = false;
     }
     this._box ? this._ripple.attachTo(this._getHostElement(), false, this._getInputElement()) :
@@ -448,7 +448,7 @@ export class MdcTextField implements AfterContentInit, OnDestroy, ControlValueAc
   setOutline(outline: boolean): void {
     this._outline = toBoolean(outline);
 
-    if (outline && this.box) {
+    if (this.outline && this.box) {
       this.box = false;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,7 @@ export class MdcTextField implements AfterContentInit, OnDestroy, ControlValueAc`
`435`	`435`	`setBox(box: boolean): void {`
`436`	`436`	`this._box = toBoolean(box);`
`437`	`437`
`438`		`- if (this.outline && box) {`
	`438`	`+ if (this.outline && this.box) {`
`439`	`439`	`this.outline = false;`
`440`	`440`	`}`
`441`	`441`	`this._box ? this._ripple.attachTo(this._getHostElement(), false, this._getInputElement()) :`
`@@ -448,7 +448,7 @@ export class MdcTextField implements AfterContentInit, OnDestroy, ControlValueAc`
`448`	`448`	`setOutline(outline: boolean): void {`
`449`	`449`	`this._outline = toBoolean(outline);`
`450`	`450`
`451`		`- if (outline && this.box) {`
	`451`	`+ if (this.outline && this.box) {`
`452`	`452`	`this.box = false;`
`453`	`453`	`}`
`454`	`454`