Skip to content

Commit 8027b63

Browse files
yardenc2003nineinchnick
authored andcommitted
Remove pre-filled deployment strategy values for better customization.
1 parent a68b3be commit 8027b63

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

charts/trino/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
504504
* `coordinator.deployment.revisionHistoryLimit` - int, default: `10`
505505

506506
The number of old ReplicaSets to retain to allow rollback.
507-
* `coordinator.deployment.strategy` - object, default: `{"rollingUpdate":{"maxSurge":"25%","maxUnavailable":"25%"},"type":"RollingUpdate"}`
507+
* `coordinator.deployment.strategy` - object, default: `{}`
508508

509509
The deployment strategy to use to replace existing pods with new ones.
510510
* `coordinator.jvm.maxHeapSize` - string, default: `"8G"`
@@ -642,7 +642,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
642642
* `worker.deployment.revisionHistoryLimit` - int, default: `10`
643643

644644
The number of old ReplicaSets to retain to allow rollback.
645-
* `worker.deployment.strategy` - object, default: `{"rollingUpdate":{"maxSurge":"25%","maxUnavailable":"25%"},"type":"RollingUpdate"}`
645+
* `worker.deployment.strategy` - object, default: `{}`
646646

647647
The deployment strategy to use to replace existing pods with new ones.
648648
* `worker.jvm.maxHeapSize` - string, default: `"8G"`

charts/trino/templates/deployment-coordinator.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ spec:
1717
replicas: 1
1818
progressDeadlineSeconds: {{ .Values.coordinator.deployment.progressDeadlineSeconds }}
1919
revisionHistoryLimit: {{ .Values.coordinator.deployment.revisionHistoryLimit }}
20+
{{- if .Values.coordinator.deployment.strategy }}
2021
strategy:
2122
{{- toYaml .Values.coordinator.deployment.strategy | nindent 4 }}
23+
{{- end }}
2224
selector:
2325
matchLabels:
2426
{{- include "trino.selectorLabels" . | nindent 6 }}

charts/trino/templates/deployment-worker.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ metadata:
1717
spec:
1818
progressDeadlineSeconds: {{ .Values.worker.deployment.progressDeadlineSeconds }}
1919
revisionHistoryLimit: {{ .Values.worker.deployment.revisionHistoryLimit }}
20+
{{- if .Values.worker.deployment.strategy }}
2021
strategy:
2122
{{- toYaml .Values.worker.deployment.strategy | nindent 4 }}
23+
{{- end }}
2224
{{- if and (not .Values.server.autoscaling.enabled) (not .Values.server.keda.enabled) }}
2325
replicas: {{ .Values.server.workers }}
2426
{{- end }}

charts/trino/values.yaml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -605,11 +605,7 @@ coordinator:
605605
revisionHistoryLimit: 10
606606
# coordinator.deployment.revisionHistoryLimit -- The number of old ReplicaSets to retain to allow rollback.
607607

608-
strategy:
609-
type: RollingUpdate
610-
rollingUpdate:
611-
maxSurge: 25%
612-
maxUnavailable: 25%
608+
strategy: {}
613609
# coordinator.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones.
614610

615611
jvm:
@@ -790,11 +786,7 @@ worker:
790786
revisionHistoryLimit: 10
791787
# worker.deployment.revisionHistoryLimit -- The number of old ReplicaSets to retain to allow rollback.
792788

793-
strategy:
794-
type: RollingUpdate
795-
rollingUpdate:
796-
maxSurge: 25%
797-
maxUnavailable: 25%
789+
strategy: {}
798790
# worker.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones.
799791

800792
jvm:

0 commit comments

Comments
 (0)