Skip to content

Commit 4e1915c

Browse files
findepiwendigo
authored andcommitted
Simplify QueryAssertions.assertQuery
Reuse QueryAssert to simplify code.
1 parent e1afe86 commit 4e1915c

1 file changed

Lines changed: 4 additions & 33 deletions

File tree

core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java

Lines changed: 4 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -200,43 +200,14 @@ public void assertQueryAndPlan(
200200

201201
private void assertQuery(Session session, @Language("SQL") String actual, @Language("SQL") String expected)
202202
{
203-
MaterializedResult actualResults = null;
204-
try {
205-
actualResults = execute(session, actual);
206-
}
207-
catch (RuntimeException ex) {
208-
fail("Execution of 'actual' query failed: " + actual, ex);
209-
}
210-
211-
MaterializedResult expectedResults = null;
212-
try {
213-
expectedResults = execute(expected);
214-
}
215-
catch (RuntimeException ex) {
216-
fail("Execution of 'expected' query failed: " + expected, ex);
217-
}
218-
219-
assertThat(actualResults.getTypes())
220-
.as("Types mismatch for query: \n " + actual + "\n:")
221-
.isEqualTo(expectedResults.getTypes());
222-
223-
List<MaterializedRow> actualRows = actualResults.getMaterializedRows();
224-
List<MaterializedRow> expectedRows = expectedResults.getMaterializedRows();
225-
226-
assertThat(actualRows).as("For query: \n " + actual).containsExactlyInAnyOrderElementsOf(expectedRows);
203+
assertThat(query(session, actual))
204+
.matches(expected);
227205
}
228206

229207
public void assertQueryReturnsEmptyResult(@Language("SQL") String actual)
230208
{
231-
MaterializedResult actualResults = null;
232-
try {
233-
actualResults = execute(actual);
234-
}
235-
catch (RuntimeException ex) {
236-
fail("Execution of 'actual' query failed: " + actual, ex);
237-
}
238-
List<MaterializedRow> actualRows = actualResults.getMaterializedRows();
239-
assertThat(actualRows).isEmpty();
209+
assertThat(query(actual))
210+
.returnsEmptyResult();
240211
}
241212

242213
public MaterializedResult execute(@Language("SQL") String query)

0 commit comments

Comments
 (0)