Fail analysis if window function uses partitioning on non orderable column

Currently execution requires symbols used for window function
partitioning to be orderable (not just comparable). We use PagesIndex
and iterating over it in order to determine partition boundaries.

This commit fixes logic of determining invalid queries.

Author: losipiuk

core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java

@@ -1469,6 +1469,11 @@ private void analyzeWindow(ResolvedWindow window, Context context, Node original
                     if (!type.isComparable()) {
                         throw semanticException(TYPE_MISMATCH, expression, "%s is not comparable, and therefore cannot be used in window function PARTITION BY", type);
                     }
+                    if (!type.isOrderable()) {
+                        // TODO this is not a hard requirement, just the implication of how we do partitioning right now, using PagesIndex and iterating over ordered values
+                        // to find partition boundaries.
+                        throw semanticException(TYPE_MISMATCH, expression, "%s is not orderable, and therefore cannot be used in window function PARTITION BY", type);
+                    }
                 }
             }
 

core/trino-main/src/test/java/io/trino/sql/analyzer/TestAnalyzer.java

@@ -280,6 +280,14 @@ public void testNonComparableWindowPartition()
                 .hasMessage("line 1:40: HyperLogLog is not comparable, and therefore cannot be used in window function PARTITION BY");
     }
 
+    @Test
+    public void testNonOrderableWindowPartition()
+    {
+        assertFails("SELECT row_number() OVER (PARTITION BY t.x) FROM (VALUES(MAP(ARRAY['key1', 'key2', 'key3' ], ARRAY[2373, 3463, 45837])) )AS t(x)")
+                .hasErrorCode(TYPE_MISMATCH)
+                .hasMessage("line 1:40: map(varchar(4), integer) is not orderable, and therefore cannot be used in window function PARTITION BY");
+    }
+
     @Test
     public void testNonComparableWindowOrder()
     {